Diagnosis complete: loops 290/291 died on transient infra retries mid-implement - #349
Merged
Merged
Conversation
linhdmn
force-pushed
the
devagent/TASK-mtyis3ci-7gvj
branch
from
September 12, 2026 21:17
f2adb77 to
3c01fae
Compare
linhdmn
added a commit
that referenced
this pull request
Sep 12, 2026
fix(ledger): release-created rows carry tag/sha again (regressed in #349)
linhdmn
added a commit
that referenced
this pull request
Sep 12, 2026
…#352) Per AGENTS.md the PRD references issues that matter for status. #349's footer claims 'a stale binary is loud'; that holds for normal-checkout builds, but Go's -buildvcs mis-stamps vcs.revision inside a linked worktree (proven A/B at 8ca0688), so worktree-built binaries write a wrong release-row revision and false-trip RunLoop's guard. Track that as #352 and link it; regenerate docs/PRD.html so the styled mirror matches PRD.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated task via
devagent task.Prompt
Diagnosis complete: loops 290/291 died on transient infra retries mid-implement (run logs show "Transient infra failure" ×2, zero commits — both task branches sit at main HEAD
85449da), and loop 289 was invalid only for goal shape (**Goal:**bold prefix). No revision work landed:internal/versionon main still has onlyVersion, noReadBuildInfoanywhere in tracked source. The research pick stays valid, is fresh from main (no dependency on the dead branches/worktrees), and is test/smoke-verifiable.Goal: Add build-revision self-identification to the Go driver so a stale binary is loud. In
internal/version/version.goadd memoizedRevision()usingdebug.ReadBuildInfo(): return vcs.revision, else "unknown" when absent (go-test binaries carry none — inject via var for tests). AddRevisionfield to the Row struct ininternal/ledger/ledger.go(~:190, besideVersion) and stamp it where rows are written. Ininternal/loopdriver/run.goRunLoop(:87) startup: compareversion.Revision()againstgit rev-parse HEAD; log a WARN "stale binary" when it is "unknown" or differs. Include the revision indevagent --version(internal/cli/root.go:240). Work from current main; ignore.devagent-worktreesdebris. Verify:go test ./internal/version/... ./internal/loopdriver/...green;go build -o /tmp/dg . && /tmp/dg --versionprints the revision.Repo policy: every PR keeps docs/PRD.md current — update the sections this change affects (status claims, architecture notes, roadmap/completion notes) and bump the Last updated footer in the same PR. A PR that changes repo state without reflecting it in docs/PRD.md is incomplete.
PRD state update (repo policy)