fix(ledger): release-created rows carry tag/sha again (regressed in #349) - #351
Merged
Merged
Conversation
) PR #349 added a Revision field to the Go ReleaseRecord but dropped Tag/SHA from the `record release` literal while still printing "(tag @ sha)" to stdout, so every Go-written release row persisted empty tag/sha — the exact Q24 fields the record exists to carry. No test covered the CLI write site, so it shipped green. - restore Tag/SHA in the ReleaseRecord literal (actions_ledger.go) - add internal/cli/actions_release_test.go pinning the CLI row shape (proven red on the regressed literal, green after) - update docs/PRD.md footer + regenerate docs/PRD.html (pandoc) so the styled mirror matches PRD.md and gains #349's build-revision line too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores
Tag/SHAthat PR #349 silently dropped from therecord releaseledger literal (rows were persisting"tag":""/"sha":""), adds a CLI-level regression test pinning the row shape, and regeneratesdocs/PRD.htmlto matchdocs/PRD.md(which was missing #349's build-revision footer line). gofmt/build/go test ./internal/cli/...green locally.