docs(i18n): add Italian model-rule translations - #95
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (8)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe pull request adds Italian documentation for model-definition rules DOL011 through DOL015. It adds an Italian rule index, links the index from the complete reference, and records the translation in the Unreleased changelog. ChangesItalian DOL rule documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds Italian documentation and an index without changing product behavior or runtime code; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (8 skipped: 8 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FROWNINGdev
left a comment
There was a problem hiding this comment.
Verified this against the canonical English source rather than reading it for fluency alone, because the last batch of translations in exactly this rule range (#90) drifted from canonical and had to be rewritten. This one holds up:
- Code blocks are byte-identical to the English originals — 3 blocks each in DOL011-DOL014, 4 in DOL015, zero differences. Nothing inside a fence got translated.
- Structure matches line-for-line: 27/30/27/27/33 lines against 27/30/27/27/33, same heading levels in the same order, rule IDs intact.
- The index table repeats the canonical metadata exactly — category, default severity and applicability for all five rules match
docs/rules/README.mdfield for field. Only prose is translated. - The index is honest about being partial, pointing at the full English reference for everything not yet covered. That is the right call for a locale that starts with one rule family.
- CHANGELOG entry sits under
### Addedabove### Fixed, which is the Keep a Changelog order, and references #52 correctly.
One nit, purely typographic. The new index line uses a plain hyphen twice where the surrounding file uses dashes:
🌐 [Italiano](../i18n/rules/it/README.md) - model rules (`DOL011`-`DOL015`)
🌐 [Tiếng Việt](../i18n/rules/vi/README.md) — queryset rules (`DOL001`–`DOL007`)
The Vietnamese line above it uses an em dash before the description and an en dash inside the range. The same applies to the DOL0NN - Title headings in the five translated files, where English and Vietnamese both use an em dash. It renders fine either way, so this is not a blocker — say the word and I will normalise it after merge rather than send you round again for three characters.
|
Merged, and normalised the dash typography myself in #97 rather than sending you back for three characters — nothing else was touched, the diff is one line per file. Worth saying why this one went in without a round of changes, because it is not the usual outcome. The last batch of translations covering exactly
If you want to keep going, the obvious next chunk is the queryset family, A PR per family is easier for both of us than one large one. No obligation — three PRs in, two of them code, you have already done more than enough. But the pattern is yours now, and copying it is the cheap part. |
Summary
Added Italian translations for the model-definition rule family (
DOL011throughDOL015). I speak Italian and reviewed the wording for technical accuracy while keeping code blocks, rule identifiers, settings, and suppression syntax unchanged.Because the project does not yet have an Italian main README, this also adds a dedicated Italian rule index and links it from the complete English rule reference.
Type of change
Test plan
npm test: 242 tests passed.cd cli && python -m pytest -q: 475 tests and 41 subtests passed, with 2 tests skipped.cd cli && python -m ruff check django_orm_lens tests: passed.cd cli && python -m mypy django_orm_lens: passed.git diff --check: passed.Checklist
cd cli && pytest -qfor Python,npm testfor TypeScript) and it is green## [Unreleased]mcp_server.pyand the relevant tests intest_mcp_server.py## Summaryabove and suggested a migration pathThe unchecked items do not apply because this PR changes Markdown documentation only and does not change runtime behavior or the MCP contract.
Related issues / discussions
Refs #52
Refs #79
Summary by CodeRabbit