docs(i18n): add Italian queryset rule translations - #100
Conversation
|
Warning Review limit reachedNext included review available in 47 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (9)
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (11)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughAdded Italian documentation for queryset rules DOL001–DOL008. Updated the Italian rule index, the main rule-reference link, and the unreleased changelog. ChangesItalian queryset documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Merge Risk: ⚪ Minimal · up to This PR adds Italian documentation for queryset rules and updates the related indexes and changelog without changing runtime behavior. The documented content matches the English structure and normal checks are passing, so no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The PR adds DOL001.md through DOL008.md, updates the Italian locale index, preserves the documented metadata and technical syntax, and matches the linked issue scope for completing the Italian queryset rule reference [ Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (11 skipped: 11 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
FROWNINGdev
left a comment
FROWNINGdev
left a comment
There was a problem hiding this comment.
Checked this the same way as #95 — mechanically against the English source, not for fluency. The translation itself is clean:
- All 24 fenced code blocks are byte-identical to the English originals. Your own count matches mine exactly.
- Line counts track the source page for page: 27/27/27/27/27/27/51/58.
- Heading levels and order match, rule IDs intact, no stray carriage returns.
- The index table repeats the canonical metadata field for field, including the row that is easiest to get wrong:
DOL008iscorrectness, notqueryset, and you have it ascorrectness. Everything else matchesdocs/rules/README.mdexactly. - Splitting the index into
Regole sui querysetand the existing model section is the right structure, and updating the intro sentence to name both families was a nice touch.
One thing needs changing, and it is the same dash nit as last time — except this round it reverts a merged fix rather than merely missing a convention.
Your branch point is d7a0ba5, which is the merge commit of #97, so the em dash was already in your base:
-🌐 [Italiano](../i18n/rules/it/README.md) — model rules (`DOL011`–`DOL015`)
+🌐 [Italiano](../i18n/rules/it/README.md) - queryset and model rules (`DOL001`-`DOL008`, `DOL011`-`DOL015`)
Merging as-is would put that line back to a hyphen four hours after it was normalised, and the Vietnamese line directly below it would visibly disagree again. The same applies to the eight new page titles, which use DOL001 - ... where English and Vietnamese use an em dash.
The convention, so it is written down somewhere you can point at:
- em dash (
—) between a rule ID and its title, and between a locale link and its description - en dash (
–) inside a rule range, e.g.DOL001–DOL008 - plain hyphens stay untouched inside code, identifiers and
django-orm-lens-disable-next-line
Nine lines total: the eight # DOL00N - titles and the locale line. Push it and I will merge — or say the word and I will fold it in on merge, same as last time. Your call; I would rather not have you spend a second round on punctuation when the actual translation has come back perfect twice running.
|
Thanks for the detailed review. I applied the requested typography changes in c5a7574: em dashes in all eight rule titles and the locale separator, plus en dashes in both rule ranges. I also rechecked that all 24 Python code blocks remain identical to the English source and that every relative Markdown link still resolves. |
FROWNINGdev
left a comment
FROWNINGdev
left a comment
There was a problem hiding this comment.
Verified c5a7574 and merging.
The fix is exactly nine lines, +1/-1 across nine files, and nothing else moved. Re-ran the same checks against the new head rather than trusting the diff:
- All eight titles now carry an em dash; the locale line carries an em dash plus en dashes in both ranges, so it finally agrees with the Vietnamese line under it.
- The 24 code blocks are still byte-identical to the English source — the typography pass did not leak into a fence.
- Line counts, heading structure and line endings unchanged.
Seven minutes from review to a surgical fix, and the translation itself came back clean twice running. #98 closes with this.
For what it is worth, the convention is now written down in the review above, so the next locale does not have to rediscover it. If you do take Spanish (#99), it is the same shape as this one and the index is the useful half — that is the piece that turns scattered pages into a section someone can navigate.
2 participants
Summary
Added Italian translations for the queryset rule family (
DOL001throughDOL008). I read and write Italian and reviewed the wording for technical accuracy while keeping code blocks, rule identifiers, settings, QuickFix labels, and suppression syntax unchanged.Updated the Italian locale index with the new family, expanded the coverage label in the complete rule reference, and recorded the addition in the changelog.
Type of change
Test plan
npm test: 242 tests passed.cd cli && python -m pytest -q: 475 tests and 41 subtests passed, with 2 tests skipped.cd cli && python -m ruff check django_orm_lens tests: passed.cd cli && python -m mypy django_orm_lens: passed.git diff --check: passed.Checklist
cd cli && pytest -qfor Python,npm testfor TypeScript) and it is green## [Unreleased]mcp_server.pyand the relevant tests intest_mcp_server.py## Summaryabove and suggested a migration pathThe unchecked items do not apply because this PR changes Markdown documentation only and does not change runtime behavior or the MCP contract.
Related issues / discussions
Closes #98
Refs #52
Summary by CodeRabbit