Skip to content

Manchester | 26-ITP-May | Fatima Rouchi | Sprint 1 | Form Controls #1354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
fatimarouchi wants to merge 6 commits into
base: main
Choose a base branch
from
+39 −9
Open

Manchester | 26-ITP-May | Fatima Rouchi | Sprint 1 | Form Controls #1354

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
2c6f76c
add customer name field
fatimarouchi May 26, 2026
684a5a0
Add customer email field
fatimarouchi May 26, 2026
89943a4
Add T-shirt color options
fatimarouchi May 26, 2026
e69848f
Add T-shirt size options
fatimarouchi May 26, 2026
3fd8326
Add submit button
fatimarouchi May 26, 2026
88569b0
remove white space from size IDs ( XS XL XXL)
fatimarouchi May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 39 additions & 9 deletions Form-Controls/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,27 +1,57 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="utf-8" />
<meta http-equiv="X-UA-Compatible" content="IE=edge" />
<meta charset="utf-8"/>
<meta http-equiv="X-UA-Compatible" content="IE=edge"/>
<title>My form exercise</title>
<meta name="description" content="" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="description" content="A simple form exercise"/>
<meta name="viewport" content="width=device-width, initial-scale=1"/>
</head>
<body>
<header>
<h1>Product Pick</h1>
</header>
<main>
<form>
<!-- write your html here-->
<!--
try writing out the requirements first as comments
this will also help you fill in your PR message later-->
<!-- label for customer name -->
<!-- label for customer email -->
<!-- label for T-Shirt color -->
<!-- label for T-Shirt size -->
<!-- submit button -->
Comment on lines +16 to +20
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need these comments?

<label for="name">Name:</label>
<input type="text" id="name" name="name" required pattern=".*\S.*\S.*"><br><br>
<label for="email">Email:</label>
<input type="email" id="email" name="email" required><br><br>
<fieldset>
<legend>T-Shirt Color:</legend>
<input type="radio" id="red" name="color" value="red" required>
<label for="red">Red</label><br>
Comment on lines +27 to +28
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider wrapping the radio button inside the label element:

<label>
  <input type="radio" id="red" name="color" value="red" required>
  Red
</label><br>

This way, you don't have to introduce the id attribute.

<input type="radio" id="blue" name="color" value="blue">
<label for="blue">Blue</label><br>
<input type="radio" id="green" name="color" value="green">
<label for="green">Green</label><br>
</fieldset><br>
<fieldset>
<legend>T-Shirt Size:</legend>
<input type="radio" id="extra-small" name="size" value="XS" required>
<label for="extra-small">XS</label><br>
<input type="radio" id="small" name="size" value="S">
<label for="small">S</label><br>
<input type="radio" id="medium" name="size" value="M">
<label for="medium">M</label><br>
<input type="radio" id="large" name="size" value="L">
<label for="large">L</label><br>
<input type="radio" id="extra-large" name="size" value="XL">
<label for="extra-large">XL</label><br>
<input type="radio" id="extra-extra-large" name="size" value="XXL">
<label for="extra-extra-large">XXL</label><br>
</fieldset><br>
<input type="submit" value="Place Order">
</form>
</main>
<footer>
<!-- change to your name-->
<p>By HOMEWORK SOLUTION</p>
<p>By Fatima Rouchi</p>
</footer>
</body>
</html>
Loading