Skip to content

Manchester | 26-ITP-May | Fatima Rouchi | Sprint 1 | Form Controls#1354

Open
fatimarouchi wants to merge 6 commits into
CodeYourFuture:mainfrom
fatimarouchi:feature/form-controls
Open

Manchester | 26-ITP-May | Fatima Rouchi | Sprint 1 | Form Controls#1354
fatimarouchi wants to merge 6 commits into
CodeYourFuture:mainfrom
fatimarouchi:feature/form-controls

Conversation

@fatimarouchi
Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Completed the Form Controls exercise:

  • Added name and email fields
  • Added T-shirt colour options
  • Added T-shirt size options
  • Added submit button
  • All fields required

Questions

No questions at the moment.

@netlify
Copy link
Copy Markdown

netlify Bot commented May 26, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 88569b0
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a15e0d63814b10007eef0e3
😎 Deploy Preview https://deploy-preview-1354--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 87 (🟢 up 1 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@fatimarouchi fatimarouchi added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. 📅 Sprint 1 Assigned during Sprint 1 of this module labels May 26, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you improve the Lighthouse Accessibility score (as reported by the browser's Lighthouse dev tool) to 100?

Image

Note: If you haven't yet enabled "Format on save" on VS Code, you may want to follow this guide to enable VS Code's
"Format on Save" option or to use its "Format Document" command. In long run it could save you a lot of time in addition to keeping your code consistently formatted.

Comment thread Form-Controls/index.html
Comment on lines +16 to +20
<!-- label for customer name -->
<!-- label for customer email -->
<!-- label for T-Shirt color -->
<!-- label for T-Shirt size -->
<!-- submit button -->
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you still need these comments?

Comment thread Form-Controls/index.html
Comment on lines +27 to +28
<input type="radio" id="red" name="color" value="red" required>
<label for="red">Red</label><br>
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consider wrapping the radio button inside the label element:

<label>
  <input type="radio" id="red" name="color" value="red" required>
  Red
</label><br>

This way, you don't have to introduce the id attribute.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants