Skip to content

client: add SelectWithExternalData(const Query&, ExternalTables) overload #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slabko merged 1 commit into from
Jun 12, 2026
+8 −0
Merged

client: add SelectWithExternalData(const Query&, ExternalTables) overload #519

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions clickhouse/client.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1354,6 +1354,10 @@ void Client::SelectWithExternalDataCancelable(const std::string& query, const st
impl_->SelectWithExternalData(Query(query, query_id).OnDataCancelable(std::move(cb)), external_tables);
}

void Client::SelectWithExternalData(const Query& query, const ExternalTables& external_tables) {
impl_->SelectWithExternalData(query, external_tables);
}

void Client::BeginExecute(const Query& query) {
impl_->BeginExecuteQuery(query);
}
Expand Down
4 changes: 4 additions & 0 deletions clickhouse/client.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,10 @@ class Client {
void SelectWithExternalDataCancelable(const std::string& query, const ExternalTables& external_tables, SelectCancelableCallback cb);
void SelectWithExternalDataCancelable(const std::string& query, const std::string& query_id, const ExternalTables& external_tables, SelectCancelableCallback cb);

/// Same as SelectWithExternalData but takes a fully-configured Query
/// (settings, params, callbacks, query_id, OnData) instead of a bare string.
void SelectWithExternalData(const Query& query, const ExternalTables& external_tables);

/// EXPERIMENTAL. Intends for execute arbitrary queries while reading the data interactively with
/// NextBlock().
void BeginExecute(const Query& query);
Expand Down
Loading