client: add SelectWithExternalData(const Query&, ExternalTables) overload#519
Merged
slabko merged 1 commit intoJun 12, 2026
Merged
Conversation
…load The Impl already took a full Query. The public surface only had the string versions, so callers could not attach settings, params, query id or OnProgress etc. when doing SELECT with external tables. Thin forwarding.
iliaal
force-pushed
the
selectwithexternaldata-query-overload
branch
from
5ff2052 to
9d15be7
Compare
slabko
approved these changes
Jun 11, 2026
slabko
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add void SelectWithExternalData(const Query& query, const ExternalTables& external_tables).
Same as the BeginInsert case: the Impl supported it, the public surface did not.
This completes the Query-based API for external-data selects.