feat: genericise EP approval UI labels via config#852
Open
TahaKhan998 wants to merge 1 commit into
Open
Conversation
TahaKhan998
force-pushed
the
feat/issue-843-genericise-ep-approval-ui-labels
branch
2 times, most recently
from
July 13, 2026 13:38
6bcfb1e to
2f15e81
Compare
TahaKhan998
force-pushed
the
feat/issue-843-genericise-ep-approval-ui-labels
branch
from
July 14, 2026 13:13
2f15e81 to
fe2de9f
Compare
palkerecsenyi
left a comment
palkerecsenyi
left a comment
Member
There was a problem hiding this comment.
Looking very nice, thank you!! I think there are 2 other places where it would be nice to have the committee name:
-
EP specifically requested us to change this to "EP Approval request workflow" to make it clearer to users what the "approval" refers to.
-
On the approval request page, the request type tag looks quite different to the tags of other request types. It would be nice for this to say "EP Approval". Currently these are set here, I am not sure how easy it is to add an instance-specific override. Don't worry about it if it's too complicated :)
TahaKhan998
force-pushed
the
feat/issue-843-genericise-ep-approval-ui-labels
branch
from
July 15, 2026 07:27
fe2de9f to
ec2e3cd
Compare
Author
Made those changes :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #843
This PR makes the EP approval UI labels configurable from CDS_COMMITTEE_APPROVAL_COMMUNITIES in invenio.cfg instead of hardcoding EP-specific wording everywhere. I used the existing label config for EP approval-style text, added optional committee_name support for review-step wording like EP Board review, and kept generic committee wording in places where direct substitution would be awkward. I also cleaned up the implementation so the workflow config is resolved through the shared helper and used consistently across the record page, request flow, and submit-notification email.