Redacted headers and added permissions check - #404
Merged
Conversation
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
pujal0909
marked this pull request as ready for review
July 30, 2026 15:26
zFernand0
requested changes
Jul 31, 2026
zFernand0
left a comment
zFernand0
left a comment
Member
There was a problem hiding this comment.
LGTM! 😋
Left some comments for consideration 🙏
I will read up a bit more on the Windows specific behavior of chmod 🤔
zFernand0
previously requested changes
Jul 31, 2026
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #404 +/- ##
==========================================
+ Coverage 82.88% 83.06% +0.18%
==========================================
Files 49 49
Lines 2950 2982 +32
==========================================
+ Hits 2445 2477 +32
Misses 505 505
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: Pujal <pujal.gandhi@broadcom.com>
traeok
approved these changes
Aug 6, 2026
traeok
left a comment
traeok
left a comment
Member
There was a problem hiding this comment.
Thanks Pujal for the fixes, LGTM!
jace-roell
approved these changes
Aug 6, 2026
t1m0thyj
approved these changes
Aug 6, 2026
t1m0thyj
left a comment
t1m0thyj
left a comment
Member
There was a problem hiding this comment.
LGTM, thanks @pujal0909! Tested on Mac and the log permissions look safe 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What It Does
Redacts sensitive values from request/response data from logs/exception messages.
Restricts log directory and log file to owner-only access
How to Test
Review Checklist
I certify that I have:
Additional Comments