feat: add Subscription Items to Node SDK (#160) - #168
Merged
Benzilla merged 2 commits intoSep 23, 2026
Merged
Conversation
Contributor
|
Looks good, thank you. Merging in now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves #160
This PR adds the
SubscriptionItemsresource to the Node SDK to expose the new public endpoints introduced in #159.SubscriptionItemsresource class, matching Stripe's SDK surface by providingcreate,retrieve,update,del, andlistmethods.CreateSubscriptionItemInput, etc.) and types from@zoneless/shared-schemasand@zoneless/shared-types.Zonelessclient export (zoneless.subscriptionItems).Type of Change
How Was This Tested?
Unit tests
Integration tests
Manual testing
Added comprehensive unit tests in
SubscriptionItems.spec.tsto verify HTTP paths, methods, and payload mapping against theHttpClientmock for all 5 methods.Verified successful compilation and test execution via
npx nx build node-sdkandnpx nx test node-sdk.Checklist
PR Checklist
npx nx run-many --target=test --all)npx nx run-many --target=lint --all)npm run format:check)