Implement request cancellation#45
Merged
Merged
Conversation
puddly
marked this pull request as ready for review
July 13, 2026 23:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will require a lot more plumbing for zigpy and ZHA to take advantage of properly and to actually be tested.
This PR provides a way to cancel requests that are still in a pending state and will (theoretically) avoid wasting airtime. A few caveats:
My eventual goal is to explore something like
interaction_idfor ZHA, where we track (in software) commands that affect an entity and cancel/replace pending ones that have been enqueued for set amount of time. For example,OnOff:off()enqueued afterOnOff:on()should replace theoncommand. A more visible application would be dragging a slider to set the color of a bulb: instead of buffering a hundred lighting commands, we rate limit to one per second.