Handle async proxy calls after event loop closes#730
Open
Wackymax wants to merge 1 commit into
Open
Conversation
Wackymax
marked this pull request as ready for review
July 16, 2026 05:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
ThreadsafeProxyconsistently return an awaitable wrapperWhy
When a threaded EZSP transport loses its connection, the worker event loop can already be closed by the time ZHA asks bellows to disconnect. The existing proxy logs
Attempted to use a closed event loopand returns plainNone, even when the proxied method is asynchronous. The caller then attempts to await that value and raises:This secondary cleanup exception can prevent Home Assistant's ZHA config-entry reload from recovering after the original transport failure.
The async wrapper now remains awaitable in every state. If the target loop is closed, awaiting it returns
None, matching the existing disconnected/no-op behavior without raising a second exception.Related reports:
Validation
test_proxy_async_loop_closedpython -m pytest -q: 425 passedgit diff --check