Skip to content

refactor: bring in types from zarr-metadata#3961

Open
d-v-b wants to merge 2 commits intozarr-developers:mainfrom
d-v-b:use-zarr-metadata
Open

refactor: bring in types from zarr-metadata#3961
d-v-b wants to merge 2 commits intozarr-developers:mainfrom
d-v-b:use-zarr-metadata

Conversation

@d-v-b
Copy link
Copy Markdown
Contributor

@d-v-b d-v-b commented May 10, 2026

replaces some of our types with exports from zarr-metadata. I expect a few related PRs, alternating between ones like this (importing types) and ones that add missing types to zarr-metadata.

TODO:

  • Add unit tests and/or doctests in docstrings
  • Add docstrings and API docs for any new/modified user-facing classes and functions
  • New/modified features documented in docs/user-guide/*.md
  • Changes documented as a new file in changes/
  • GitHub Actions have all passed
  • Test coverage is 100% (Codecov passes)

@github-actions github-actions Bot added the needs release notes Automatically applied to PRs which haven't added release notes label May 10, 2026
@d-v-b d-v-b requested a review from ilan-gold May 10, 2026 08:38
@d-v-b
Copy link
Copy Markdown
Contributor Author

d-v-b commented May 10, 2026

cc @chuckwondo

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.25%. Comparing base (84532ca) to head (3ddf811).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3961      +/-   ##
==========================================
- Coverage   93.26%   93.25%   -0.01%     
==========================================
  Files          87       87              
  Lines       11721    11706      -15     
==========================================
- Hits        10932    10917      -15     
  Misses        789      789              
Files with missing lines Coverage Δ
src/zarr/codecs/blosc.py 95.04% <100.00%> (-0.12%) ⬇️
src/zarr/codecs/cast_value.py 98.58% <100.00%> (-0.02%) ⬇️
src/zarr/core/metadata/v2.py 88.95% <100.00%> (-0.07%) ⬇️
src/zarr/core/metadata/v3.py 93.69% <100.00%> (-0.17%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs release notes Automatically applied to PRs which haven't added release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant