Repository navigation
feat: add init chart values schemas - #5347
Merged
brandtkeller merged 3 commits intoOct 1, 2026
Merged
Conversation
✅ Deploy Preview for zarf-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 🚀 New features to boost your workflow:
|
brandtkeller
requested changes
Sep 12, 2026
brandtkeller
left a comment
Member
There was a problem hiding this comment.
Generally looks good! minor nit on quantity types. I appreciate the enums. I think some of these could be hardened further with patterns but wouldn't require it here.
Could we also patch bump these charts for visibility?
acald-creator
force-pushed
the
feat/init-chart-value-schemas
branch
from
September 22, 2026 02:37
54d865a to
0bc0261
Compare
brandtkeller
self-requested a review
September 23, 2026 22:33
brandtkeller
approved these changes
Sep 23, 2026
brandtkeller
left a comment
Member
There was a problem hiding this comment.
lgtm - thanks for this improvement!
a1994sc
approved these changes
Sep 24, 2026
Contributor
|
LGTM |
Member
|
ah! @acald-creator we have signed commits enforced - could you re-sign your commits? Provided you have this configured it usually looks something like: git fetch origin
git rebase --exec 'git commit --amend --no-edit -S -s' origin/main
git push --force-with-lease |
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
acald-creator
force-pushed
the
feat/init-chart-value-schemas
branch
from
September 26, 2026 12:24
0bc0261 to
b4e22a5
Compare
2 tasks
sei-pearl
pushed a commit
to sei-pearl/zarf
that referenced
this pull request
Oct 1, 2026
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
values.schema.jsonfiles to the internalzarf-agentandzarf-registryHelm charts.Validation
helm lintfor both charts.Related Issue
Fixes #5309
Checklist before merging