Skip to content

feat: add init chart values schemas - #5347

Merged
brandtkeller merged 3 commits into
zarf-dev:mainfrom
acald-creator:feat/init-chart-value-schemas
Oct 1, 2026
Merged

brandtkeller merged 3 commits into
zarf-dev:mainfrom
acald-creator:feat/init-chart-value-schemas

Conversation

@acald-creator

Copy link
Copy Markdown
Contributor

Description

  • Add values.schema.json files to the internal zarf-agent and zarf-registry Helm charts.
  • Validate chart values against the schemas so invalid configuration is caught during Helm validation.

Validation

  • Ran helm lint for both charts.
  • Confirmed valid values pass and invalid values are rejected.

Related Issue

Fixes #5309

Checklist before merging

@netlify

netlify Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for zarf-docs canceled.

Name Link
🔨 Latest commit b4e22a5
🔍 Latest deploy log https://app.netlify.com/projects/zarf-docs/deploys/6ab7b96294191300084a94ee

@codecov

codecov Bot commented Sep 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
see 39 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@brandtkeller brandtkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good! minor nit on quantity types. I appreciate the enums. I think some of these could be hardened further with patterns but wouldn't require it here.

Could we also patch bump these charts for visibility?

Comment thread packages/zarf-agent/chart/values.schema.json
@github-project-automation github-project-automation Bot moved this to In progress in Zarf Sep 12, 2026
@acald-creator
acald-creator force-pushed the feat/init-chart-value-schemas branch from 54d865a to 0bc0261 Compare September 22, 2026 02:37
@brandtkeller
brandtkeller self-requested a review September 23, 2026 22:33

@brandtkeller brandtkeller left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - thanks for this improvement!

@a1994sc

a1994sc commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

LGTM

@brandtkeller

Copy link
Copy Markdown
Member

ah! @acald-creator we have signed commits enforced - could you re-sign your commits?

Provided you have this configured it usually looks something like:

git fetch origin
git rebase --exec 'git commit --amend --no-edit -S -s' origin/main
git push --force-with-lease

Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
@acald-creator
acald-creator force-pushed the feat/init-chart-value-schemas branch from 0bc0261 to b4e22a5 Compare September 26, 2026 12:24
@brandtkeller
brandtkeller added this pull request to the merge queue Oct 1, 2026
Merged via the queue into zarf-dev:main with commit 4c238cc Oct 1, 2026
31 checks passed
@github-project-automation github-project-automation Bot moved this from In progress to Done in Zarf Oct 1, 2026
sei-pearl pushed a commit to sei-pearl/zarf that referenced this pull request Oct 1, 2026
Signed-off-by: Antonette Caldwell <18711313+acald-creator@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add chart values schemas to internal init charts

3 participants