Apply Spring Boot connection validation settings to HttpClient - #1883
Merged
fatroom merged 2 commits intoSep 16, 2026
Merged
Conversation
vadimturkov
requested review from
fatroom and
lukasniemeier-zalando
as code owners
September 8, 2026 05:43
Contributor
|
👍 |
1 similar comment
Author
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change ensures
time-to-liveandvalidate-after-inactivityare merged correctly and applied to the underlyingConnectionConfig, including the default configuration for the Spring Boot starter.Description
This PR fixes the Spring Boot auto-configuration for Apache HttpClient connections by ensuring the connection lifecycle settings are correctly merged and applied.
The update adds
validate-after-inactivityto the Spring Boot properties model, keeps the default value consistent with the starter defaults, and ensures client-specific values override the default configuration as expected. It also wires bothtime-to-liveandvalidate-after-inactivityinto the underlyingConnectionConfigused by the pooled HttpClient.In addition, the documentation was updated to describe the new property and regression tests were added to cover both defaulting and configuration behavior.
Motivation and Context
The Spring Boot auto-configured HttpClient was missing part of the connection configuration. In particular, the inactivity validation setting was not being merged or applied, which could allow stale pooled connections to remain active longer than intended.
This change ensures that connection lifetime and inactivity validation are configured consistently for Riptide clients using the Spring Boot starter.
Types of changes
Checklist: