docs(shell-state): correct the note on why assertions live in fixtures - #117
Merged
Conversation
The comment said a `$' in the zi_test argument is not reliably deferred to the inner shell. That described a fork-only defect in zunit, fixed by z-shell/zunit#25; upstream, which this suite runs against in CI, never had it. The fixture layout is still right, for a better reason: a sourced file is parsed only by the shell that sources it, so no zunit build can change what these tests measure. Say that instead. Comments only. No test behaviour changes. Refs z-shell/zunit#25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
shell-statecomment said a$in thezi_testargument is not reliably deferred to the inner shell. That described a fork-only defect in ZUnit, fixed by z-shell/zunit#25. Upstream, which this repository installs in CI, never had it, so the note was wrong about the build these tests actually run under.The fixture layout is still correct, for a better reason: a sourced file is parsed only by the shell that sources it, so no ZUnit build can change what these tests measure. The comment now says that.
Comments only.
tests/shell-state.zunitstill passes 3/3.Refs z-shell/zunit#25