Fix dialog compatibility and semantic material initialization - #98
Open
winterclincke wants to merge 2 commits into
Open
winterclincke wants to merge 2 commits into
winterclincke wants to merge 2 commits into
Conversation
UE 5.8.2 compilation fails with MSVC C2665 at all five titled FMessageDialog::Open calls in the CSV importer and render widget. The available overload accepts const FText&, not const FText*. Pass the existing title by reference without changing dialog behavior. Validation: the original local build_plugin.log records all five errors; build_dialog_fix.log records a successful rebuild after this change. The installed UE 5.8 MessageDialog.h confirms the reference signature.
UE 5.8.2 editor startup reports that the reflected object property FSemanticClass::PlainColorMaterialInstance is not initialized properly, followed by automation condition failures. Default construction leaves the raw pointer indeterminate, although GetSemanticClassMaterial uses nullptr to decide whether to create it. Initialize it to nullptr so default semantic classes are valid. Validation: the original editor.log records the member-initialization failure. Corrected editor sessions and subsequent semantic captures no longer report it. This is an existing initialization defect observed on UE 5.8, not a new annotation feature or a proven 5.8-only regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation