CI: add apt-install.sh for unification and robustness - #11629
Open
padelsbach wants to merge 1 commit into
Open
padelsbach wants to merge 1 commit into
padelsbach wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Zero-value validation and the Falcon job’s insufficient timeout budget undermine the intended robustness.
Review effort: Balanced
Findings: 2
Open (2)
What changed in this PR
Centralizes robust apt installation behavior for CI workflows and composite actions.
Changes:
- Adds a reusable apt installer with retries, timeouts, and vendor-source handling.
- Migrates CI jobs and dependency-bundle generation to the shared script.
- Expands SBOM dependencies and avoids amd64 bundles on non-x64 runners.
| File | Description |
|---|---|
.github/scripts/apt-install.sh |
Adds the shared apt installation utility. |
.github/scripts/download-deb-closure.sh |
Uses the shared utility for bundle downloads. |
.github/actions/install-apt-deps/action.yml |
Delegates apt fallback and adds architecture gating. |
.github/actions/ccache-setup/action.yml |
Reuses the shared installer for ccache. |
.github/workflows/sbom.yml |
Uses bundled apt dependencies for SBOM tooling. |
.github/workflows/falcon-interop.yml |
Migrates Falcon jobs to the apt action. |
.github/workflows/cross-library.yml |
Bootstraps and uses the installer in containers. |
.github/workflows/cross-library/README.md |
Documents the new bootstrap process. |
.github/workflows/ci-deps-image.yml |
Uses the installer when producing dependency bundles. |
.github/workflows/afalg.yml |
Uses best-effort shared installation for kernel modules. |
.github/ci-deps/packages-ubuntu-24.04-full.txt |
Adds SBOM build dependencies to the full bundle. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
padelsbach
force-pushed
the
ci-apt-wrapper
branch
from
October 2, 2026 00:33
0ee5c5b to
a4fd12a
Compare
| sleep $DELAY | ||
| DELAY=$((DELAY * 2)) | ||
| done | ||
| "$GITHUB_ACTION_PATH/../../scripts/apt-install.sh" \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Unify several copypasta apt install loops into
apt-install.sh. Handles timeouts for robustness in a uniform way.Testing
CI
Checklist