Fix memory leaks in wolfSSL_d2i_OCSP_RESPONSE reuse branch. Avoid using stale nonces when OCSP stapling is enabled at the context level. - #11628
Open
kareem-wolfssl wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new test breaks TLS-1.3-only builds, and the V2 nonce path lacks targeted coverage.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Fixes OCSP response reuse leaks and stale context-level stapling nonces.
Changes:
- Frees complete reused OCSP response chains and resets stale references.
- Generates per-connection OCSP nonces.
- Adds regression tests for response reuse and nonce freshness.
| File | Description |
|---|---|
src/ocsp.c |
Corrects OCSP response reuse cleanup. |
src/tls.c |
Refreshes context-configured stapling nonces. |
tests/api/test_ocsp.c |
Adds OCSP regression tests. |
tests/api/test_ocsp.h |
Declares new tests. |
tests/api.c |
Registers new tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Thanks to Anthropic for the report.
… level. Thanks to Anthropic for the report.
kareem-wolfssl
force-pushed
the
zd22448_ocsp
branch
from
October 2, 2026 22:22
0dc609f to
ba6c3d9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partially fixes zd#22448
Testing
Built in + added tests, reproducers
Checklist