TLS ECH: cleanup tests and state management - #11626
Open
sebastian-carpenter wants to merge 1 commit into
Open
sebastian-carpenter wants to merge 1 commit into
sebastian-carpenter wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The refactor removes the only HRR coverage for clearing retry configurations after authentication failure.
Review effort: Balanced
Findings: 1
What changed in this PR
Cleans up TLS ECH state handling, diagnostics, interoperability, and tests.
Changes:
- Routes ECH configuration and response state through the ECH extension.
- Expands and simplifies ECH/SNI tests.
- Adds ECH status logging and runtime-generated rejection configs.
| File | Description |
|---|---|
wolfssl/test.h |
Adds ECH status output helper. |
tests/api.c |
Refactors and expands ECH tests. |
src/tls13.c |
Simplifies ECH state access during TLS 1.3 handshakes. |
src/tls.c |
Moves ECH response setup and config access into parsing. |
examples/server/server.c |
Logs server ECH status. |
examples/client/client.c |
Logs client ECH status. |
.github/scripts/openssl-ech.sh |
Generates rejection configs dynamically and improves synchronization. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
sebastian-carpenter
force-pushed
the
tls-ech-tweaks
branch
from
October 2, 2026 15:38
8d88ae7 to
6594f04
Compare
Contributor
|
jenkins retest this please |
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11626
Scan targets checked: wolfssl-src, wolfssl-bugs
Coverage: 3 of 4 in-scope changed file(s) opened by the reviewer; not opened: wolfssl/test.h
Fenrir result: Approved ✅
No new issues found in the changed files.
Advisory only — this automated result does not count as a GitHub approval.
Review tier: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Breaking some changes out of #10913.
Code:
Testing:
Examples:
Openssl Interop:
Checklist