Add crypto callback for Frodo-kem - #11238
Open
padelsbach wants to merge 5 commits into
Open
padelsbach wants to merge 5 commits into
padelsbach wants to merge 5 commits into
Conversation
padelsbach
force-pushed
the
crypto-cb-frodo
branch
3 times, most recently
from
August 26, 2026 18:05
43ab6f8 to
a96b311
Compare
padelsbach
force-pushed
the
crypto-cb-frodo
branch
3 times, most recently
from
September 3, 2026 03:36
b81945c to
327628e
Compare
wolfSSL-Fenrir-bot
requested changes
Sep 9, 2026
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #11238
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 7
7 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Reported findings require changes before merge.
padelsbach
force-pushed
the
crypto-cb-frodo
branch
3 times, most recently
from
September 17, 2026 06:05
d465827 to
daad8ce
Compare
padelsbach
force-pushed
the
crypto-cb-frodo
branch
from
September 28, 2026 21:38
260f7f2 to
7577775
Compare
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
crypto-cb-frodo
branch
2 times, most recently
from
September 29, 2026 17:08
97061da to
8bada36
Compare
padelsbach
force-pushed
the
crypto-cb-frodo
branch
from
October 1, 2026 16:50
8bada36 to
61a4d75
Compare
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Finder-based cleanup can dispatch duplicate device frees, and the new configure mapping lacks direct CI coverage.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Adds FrodoKEM crypto-callback offloading and a callback-only mode that removes native lattice operations.
Changes:
- Routes FrodoKEM key generation, encapsulation, decapsulation, and cleanup through crypto callbacks.
- Strips portable and assembly implementations in callback-only builds.
- Adds configuration, CI, and callback-dispatch tests.
| File | Description |
|---|---|
wolfssl/wolfcrypt/wc_frodokem.h |
Adds device context and native-mode marker. |
wolfssl/wolfcrypt/settings.h |
Validates callback-only configuration. |
wolfcrypt/test/test.c |
Adds callback and finder tests. |
wolfcrypt/src/wc_frodokem.c |
Implements callback routing and native stripping. |
wolfcrypt/src/wc_frodokem_mat.c |
Excludes native matrix operations. |
wolfcrypt/src/wc_frodokem_asm.S |
Excludes x86 assembly. |
wolfcrypt/src/wc_frodokem_asm.asm |
Excludes Windows x86 assembly. |
wolfcrypt/src/port/arm/thumb2-frodokem-asm.S |
Excludes Thumb-2 assembly. |
wolfcrypt/src/port/arm/thumb2-frodokem-asm_c.c |
Excludes inline Thumb-2 assembly. |
wolfcrypt/src/port/arm/armv8-frodokem-asm.S |
Excludes AArch64 assembly. |
wolfcrypt/src/port/arm/armv8-frodokem-asm.asm |
Excludes ARM assembler implementation. |
wolfcrypt/src/port/arm/armv8-frodokem-asm_c.c |
Excludes inline AArch64 assembly. |
wolfcrypt/src/port/arm/armv8-32-frodokem-asm.S |
Excludes ARMv8-32 assembly. |
wolfcrypt/src/port/arm/armv8-32-frodokem-asm_c.c |
Excludes inline ARMv8-32 assembly. |
wolfcrypt/src/cryptocb.c |
Enables finder-based PQC KEM dispatch. |
tests/api/test_frodokem.c |
Skips native-only tests in callback-only mode. |
configure.ac |
Adds FrodoKEM to cryptocb=only. |
.github/workflows/cryptocb-only.yml |
Adds callback-only CI configurations. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
philljj
requested changes
Oct 1, 2026
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
crypto-cb-frodo
branch
from
October 2, 2026 17:18
5024198 to
bd9e516
Compare
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
crypto-cb-frodo
branch
2 times, most recently
from
October 2, 2026 23:14
3e05ce4 to
a2bec77
Compare
Contributor
Author
|
jenkins retest this please |
padelsbach
force-pushed
the
crypto-cb-frodo
branch
from
October 3, 2026 03:44
a2bec77 to
2c85d38
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Includes CB_ONLY mode which saves approx 22kB when enabled and offloaded.
Also includes a minor fix for WOLF_CRYPTO_CB_FIND.
Testing
New unit tests
Checklist