Skip to content

fix: update debian/copyright to GPL-3+ and add missing attributions - #10719

Open
MarkAtwood wants to merge 2 commits into
wolfSSL:masterfrom
MarkAtwood:fix/debian-copyright-gplv3
Open

MarkAtwood wants to merge 2 commits into
wolfSSL:masterfrom
MarkAtwood:fix/debian-copyright-gplv3

Conversation

@MarkAtwood

@MarkAtwood MarkAtwood commented Jun 17, 2026 •

Copy link
Copy Markdown
Contributor

Summary

The debian/copyright file was out of date in several ways:

  • GPL-2+ -> GPL-3+: wolfSSL has been GPL-3.0 (per COPYING) but debian/copyright still declared GPL-2+
  • camellia.c/h license: was declared GPL-2+ only. Both files carry two headers: NTT's BSD-2-Clause block first, then a wolfSSL Inc. GPL-3+ block. Now declared NTT-BSD-2-Clause and GPL-3+
  • Missing blake2b.c/blake2s.c: same two-header pattern (Samuel Neves CC0-1.0, then wolfSSL Inc. GPL-3+), never listed at all. Now declared CC0-1.0 and GPL-3+ with both copyright holders
  • Missing visibility.m4: FSF copyright, FSFAP license, never listed
  • Copyright year: updated 2023 -> 2026
  • debian/ stanza*: added wolfSSL Inc. 2024-2026 alongside original Felix Lechner attribution

DEP-5 is last-match-wins, so the camellia and blake2 stanzas fully govern those files. The Files: * GPL-3+ stanza does not backfill them, which is why both need the conjunction rather than the upstream license alone.

No code changes -- metadata only.

Test plan

  • Parses under python3-debian Copyright(strict=True); both conjunctions resolve and all 7 named licenses have standalone paragraphs
  • lintian on built .deb shows no incorrect-source-license or missing-license-paragraph warnings

Copilot AI review requested due to automatic review settings June 17, 2026 17:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

Refresh Debian DEP-5 licensing metadata to align with upstream licensing and ensure all bundled third-party sources/macros are properly attributed.

Changes:

  • Update primary package licensing from GPL-2+ to GPL-3+ and refresh wolfSSL copyright years.
  • Add missing Files: stanzas and license paragraphs for Camellia (NTT BSD-2-Clause), BLAKE2 (CC0-1.0), and m4/visibility.m4 (FSFAP).
  • Normalize license identifiers / formatting (e.g., BSD-3-Clause, fixed email bracket), and extend debian/* attribution.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread debian/copyright
Comment thread debian/copyright Outdated
@MarkAtwood
MarkAtwood requested review from cconlon, dgarske and wolfSSL-Bot and removed request for dgarske June 17, 2026 18:06
@github-actions

github-actions Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

MemBrowse Memory Report

gcc-arm-cortex-m0plus

  • FLASH: .text +3,048 B (+4.7%, 67,931 B / 262,144 B, total: 26% used)

gcc-arm-cortex-m3

  • FLASH: .rodata.SetCipherList_ex.str1.1 +10 B, .text +4,336 B (+3.5%, 127,925 B / 262,144 B, total: 49% used)
  • RAM: .bss +4 B (+0.5%, 820 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m4

  • FLASH: .rodata.CSWTCH.1 +24 B, .rodata.SetCipherList_ex.str1.1 +10 B, .rodata.str1.1 +219 B, .text +4,544 B (+2.4%, 206,636 B / 262,144 B, total: 79% used)
  • RAM: .bss +4 B (+0.5%, 840 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m4-baremetal

  • FLASH: .text +2,944 B (+4.4%, 70,371 B / 262,144 B, total: 27% used)

gcc-arm-cortex-m4-crypto-only

  • FLASH: .rodata.CSWTCH.1 +24 B, .rodata.str1.1 +219 B, .text +3,392 B (+2.1%, 179,613 B / 262,144 B, total: 69% used)

gcc-arm-cortex-m4-dtls13

  • FLASH: .rodata +136 B, .text +7,936 B (+4.4%, 190,980 B / 1,048,576 B, total: 18% used)
  • RAM: .bss +4 B (+0.5%, 856 B / 262,144 B, total: 0% used)

gcc-arm-cortex-m4-min-ecc

  • FLASH: .text +2,752 B (+4.4%, 65,157 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-openssl-compat

  • FLASH: .rodata +800 B, .text +12,672 B (+1.7%, 789,020 B / 1,048,576 B, total: 75% used)
  • RAM: .bss +1,564 B (+1.1%, 138,508 B / 262,144 B, total: 53% used)

gcc-arm-cortex-m4-pkcs7

  • FLASH: .rodata.CSWTCH.1 +24 B, .rodata.str1.1 +219 B, .text +4,672 B (+2.3%, 219,742 B / 262,144 B, total: 84% used)

gcc-arm-cortex-m4-pq

  • FLASH: .rodata +276 B, .text +9,024 B (+3.1%, 306,928 B / 1,048,576 B, total: 29% used)
  • RAM: .bss +8,804 B (+26.3%, 42,228 B / 262,144 B, total: 16% used)

gcc-arm-cortex-m4-rsa-only

  • FLASH: .rodata +256 B, .text +8,768 B (+2.8%, 337,136 B / 1,048,576 B, total: 32% used)
  • RAM: .bss +8,804 B (+26.3%, 42,224 B / 262,144 B, total: 16% used)

gcc-arm-cortex-m4-sp-math

  • FLASH: .text +2,752 B (+4.4%, 65,157 B / 262,144 B, total: 25% used)

gcc-arm-cortex-m4-tls12

  • FLASH: .rodata.SetCipherList_ex.str1.1 +10 B, .text +4,352 B (+3.5%, 128,701 B / 262,144 B, total: 49% used)
  • RAM: .bss +4 B (+0.5%, 820 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m4-tls13

  • FLASH: .rodata.CSWTCH.1 +24 B, .rodata.CSWTCH.196 +6 B, .rodata.SetCipherList_ex.str1.1 +10 B, .rodata.str1.1 +219 B, .text +7,296 B (+3.2%, 245,918 B / 262,144 B, total: 94% used)
  • RAM: .bss +8,804 B (+26.4%, 42,176 B / 65,536 B, total: 64% used)

gcc-arm-cortex-m7

  • FLASH: .rodata.CSWTCH.1 +24 B, .rodata.SetCipherList_ex.str1.1 +10 B, .rodata.str1.1 +219 B, .text +4,544 B (+2.4%, 206,636 B / 262,144 B, total: 79% used)
  • RAM: .bss +4 B (+0.5%, 840 B / 65,536 B, total: 1% used)

gcc-arm-cortex-m7-pq

  • FLASH: .rodata +276 B, .text +9,088 B (+3.1%, 307,888 B / 1,048,576 B, total: 29% used)
  • RAM: .bss +8,804 B (+26.3%, 42,228 B / 262,144 B, total: 16% used)

gcc-arm-cortex-m7-tls13

  • FLASH: .rodata.CSWTCH.1 +24 B, .rodata.CSWTCH.196 +6 B, .rodata.SetCipherList_ex.str1.1 +10 B, .rodata.str1.1 +219 B, .text +7,232 B (+3.1%, 245,918 B / 262,144 B, total: 94% used)
  • RAM: .bss +8,804 B (+26.4%, 42,176 B / 65,536 B, total: 64% used)

linuxkm-pie

  • Data: __patchable_function_entries +1,936 B (+7.3%, 28,504 B)

linuxkm-standard

  • Data: __patchable_function_entries +1,952 B (+4.0%, 51,328 B)

stm32-sim-stm32h753

  • FLASH: .text +6,948 B (+3.7%, 193,108 B / 2,097,152 B, total: 9% used)

@MarkAtwood
MarkAtwood force-pushed the fix/debian-copyright-gplv3 branch from 12decc3 to a85a6b8 Compare August 13, 2026 00:14

@JacobBarthelmeh JacobBarthelmeh left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lintian results :

  Copyright-related tags: exactly one, and it's pre-existing

  W: wolfssl source: superfluous-file-pattern m4/ax_check_library.m4       
  [debian/copyright:54]
  
  m4/ax_check_library.m4 is listed in a Files: stanza but doesn't exist in the
  tree. This stanza is untouched by the diff, it's at line 47 in master's
  copyright too, so the change neither introduced nor fixed it.

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor

Retest this please Jenkins

m4/ax_check_library.m4 no longer exists in the tree; lintian flags the
stanza as superfluous-file-pattern.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants