fix: update debian/copyright to GPL-3+ and add missing attributions - #10719
Open
MarkAtwood wants to merge 2 commits into
Open
MarkAtwood wants to merge 2 commits into
MarkAtwood wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Refresh Debian DEP-5 licensing metadata to align with upstream licensing and ensure all bundled third-party sources/macros are properly attributed.
Changes:
- Update primary package licensing from GPL-2+ to GPL-3+ and refresh wolfSSL copyright years.
- Add missing
Files:stanzas and license paragraphs for Camellia (NTT BSD-2-Clause), BLAKE2 (CC0-1.0), andm4/visibility.m4(FSFAP). - Normalize license identifiers / formatting (e.g., BSD-3-Clause, fixed email bracket), and extend
debian/*attribution.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MarkAtwood
requested review from
cconlon,
dgarske and
wolfSSL-Bot
and removed request for
dgarske
June 17, 2026 18:06
|
6 tasks
MarkAtwood
force-pushed
the
fix/debian-copyright-gplv3
branch
from
August 7, 2026 20:51
5686989 to
12decc3
Compare
MarkAtwood
force-pushed
the
fix/debian-copyright-gplv3
branch
from
August 13, 2026 00:14
12decc3 to
a85a6b8
Compare
JacobBarthelmeh
left a comment
Contributor
There was a problem hiding this comment.
Lintian results :
Copyright-related tags: exactly one, and it's pre-existing
W: wolfssl source: superfluous-file-pattern m4/ax_check_library.m4
[debian/copyright:54]
m4/ax_check_library.m4 is listed in a Files: stanza but doesn't exist in the
tree. This stanza is untouched by the diff, it's at line 47 in master's
copyright too, so the change neither introduced nor fixed it.
Contributor
|
Retest this please Jenkins |
2 of 4 tasks
m4/ax_check_library.m4 no longer exists in the tree; lintian flags the stanza as superfluous-file-pattern.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
debian/copyrightfile was out of date in several ways:NTT-BSD-2-Clause and GPL-3+CC0-1.0 and GPL-3+with both copyright holdersDEP-5 is last-match-wins, so the camellia and blake2 stanzas fully govern those files. The
Files: *GPL-3+ stanza does not backfill them, which is why both need the conjunction rather than the upstream license alone.No code changes -- metadata only.
Test plan
python3-debianCopyright(strict=True); both conjunctions resolve and all 7 named licenses have standalone paragraphslintianon built .deb shows noincorrect-source-licenseormissing-license-paragraphwarnings