Fix minor issues and Add test vectors#979
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR makes three small fixes plus a corresponding test addition: it removes a dead conditional in the SCP client example, hardens GetConfigInt() against NULL/empty input, and replaces the manual single-flag attribute parsing in wolfSSH_SFTP_RecvMKDIR() with the canonical SFTP_ParseAttributes_buffer() helper.
Changes:
- Remove unreachable
err_sys("Couldn't set the channel type.")block inscp_client(). - Validate
in/inSzinGetConfigInt()and useelse iffor thehmultiplier; add tests for barem/hvalues. - Use
SFTP_ParseAttributes_buffer()inwolfSSH_SFTP_RecvMKDIR()so permission attributes can be honored even when combined with other flags.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| examples/scpclient/scpclient.c | Removes dead duplicate ret != WS_SUCCESS check after socket-set call. |
| apps/wolfsshd/configuration.c | Adds NULL/empty input guard and makes m/h multiplier checks mutually exclusive in GetConfigInt(). |
| apps/wolfsshd/test/test_configuration.c | Adds test vectors for bare m/h multiplier values to LoginGraceTime. |
| src/wolfsftp.c | Replaces ad-hoc attribute flag parsing in MKDIR handler with SFTP_ParseAttributes_buffer(), honoring WOLFSSH_FILEATRB_PERM when set alongside other flags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ejohnstown
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the following things:
Also, this adds the test vector for GetConfigInt().
Addressed by f_3443, f_3670 and f_3875.