esp: fenrir fixes

[philljj]

Description

misc fixes:

• esp_print_field: handle short (< 4) fields (F-11437).
• esp_transport_wrap: defer esp_state_save until success (F-13163).
• esp_send: handle esp_send err (F-6032).
• esp_send: check len not greater than frame (F-13205).

[Copilot]

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

Review effort: Lite
Findings: 3 · 2

Open (5)

• ESP_LOG uses printf-style formatting; passing a uint32_t val_len to %d is a varargs type… · New
• ESP_LOG uses printf-style formatting; passing a uint32_t val_len to %d is a varargs type… · New
• esp_len appears to be an unsigned length; using %d is a varargs type mismatch if the underlying… · New
• The block comment ending * */ is non-idiomatic and the wording is slightly unclear. Consider… · New
• For short fields, the log prints a placeholder row but omits the actual bytes, which makes… · New

What changed in this PR

This PR applies two ESP-related fixes: safer debug printing for short packet fields and deferring ESP state persistence until the wrap operation succeeds.

Changes:

• Update esp_print_field to avoid out-of-bounds reads when a field is shorter than 4 bytes.
• Defer esp_state_save() until the end of esp_transport_wrap() after successful packet construction.
• Switch several debug prints from LOG to ESP_LOG in the DEBUG_ESP path.

File	Description
src/​wolfesp.c	Fix short-field debug printing and adjust outbound ESP sequence/state saving semantics

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.