fix: pipe binding test output on Windows - #641
Open
mikemikimike wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #638
On Windows,
fork()with all stdio streams ignored can exit before the binding test child sends itsreadymessage. This makes the Vulkan prebuilt binding appear unavailable and can trigger an unnecessary source build.This change defaults the binding test's child output streams to pipes on Windows, and makes the public
getLlamaForOptionspath use the same platform-specific default. ExplicitpipeOutputOnNodeandpipeBinaryTestErrorLogsvalues still take precedence.Added a mocked IPC regression test covering the Windows default and the explicit override.
Validation:
npm run test:typescriptnpm exec -- vitest run test/standalone/bindings/testBindingBinary.test.ts --reporter=verbose --pool=forks --maxWorkers=1npm run lint:eslintnpm run formatnpm run buildgit diff --checkThe full standalone suite was attempted, but its local llama.cpp CMake/MSBuild build did not complete in this Windows environment; no external API or GPU service was used by the regression test.