Add bn-sylo to language-data - #518
Conversation
b67d5ee to
f2033a7
Compare
srish
left a comment
There was a problem hiding this comment.
@CoderAnimesh Thanks for the PR! ꠍꠤꠟꠐꠤ ꠘꠣꠉꠞꠤ reads as the script's name ("Sylheti Nagri"), but autonyms are usually the language's name. Should this be "Bangla" in Sylheti Nagri? If ꠍꠤꠟꠐꠤ ꠘꠣꠉꠞꠤ is intended, could you share a source for it?
|
@srish , Thank you for the comment , There is no any idea about that we have to make that whole thing on language data repo in the bangla language names... |
|
@CoderAnimesh Okay sounds good! I have added a comment on this task: https://phabricator.wikimedia.org/T438600. |
|
I agree with @srish that we need to add language name here (ꠛꠣꠋꠟꠣ) instead of script (ꠍꠤꠟꠐꠤ ꠘꠣꠉꠞꠤ) |
|
@bodhisattwawiki Thanks for confirming! @CoderAnimesh could you update the autonym to ꠛꠣꠋꠟꠣ in langdb.yaml and regenerate language-data.json? |
|
Sure @srish , |
Add bn-sylo (Bangla in Sylheti Nagri script) to support the language converter and ULS on bn.wikisource.org. Bug: T438611 Change-Id: I755b5932125f03e2de7c13b82ab0a4ea68c13fb6
f2033a7 to
81493f6
Compare
|
I have updated the commit according to the conversation.. |
srish
left a comment
There was a problem hiding this comment.
@CoderAnimesh Thanks for making the changes! Autonym looks good now. It looks like now we have two lines with version numbers. Make sure that there is only the updated one and changes in data/language-data.json have been automatically generated following the instructions in https://www.mediawiki.org/wiki/Manual:Adding_and_removing_languages#language-data rather than manually.
|
@srish , I have done the updates in commit ... |
Downstream task: https://phabricator.wikimedia.org/T438611