fix(finder): observe mounted volumes and their lifecycle to support external/network drives (fixes #148, #150) - #152
Merged
wflixu merged 1 commit intoSep 13, 2026
Conversation
Register each mounted volume explicitly and apply workspace mount, unmount and rename paths without trusting stale unmount enumeration. Add lifecycle regression coverage and document the real DMG probe and remaining signed Finder verification. Fixes wflixu#148 Fixes wflixu#150
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #148
Fixes #150
Currently,
setupObservingDirectories()inFinderSyncExtonly registers["/"]. In macOS's VFS architecture, external drives, mounted DMGs, and network shares (SMB/NFS/AFP) reside under/Volumes/<VolumeName>, which are separate file system mount points not covered by root volume-only observation in FinderSync. As a result, right-click context menus fail to appear on external or network volumes.This PR fixes this by:
/and each currently mounted volume (FileManager.default.mountedVolumeURLs).MountedVolumeObserverto dynamically listen toNSWorkspace.didMountNotification,didUnmountNotification, anddidRenameVolumeNotificationonNSWorkspace.shared.notificationCenter.FIFinderSyncController.default().directoryURLsincrementally to prevent stale references when drives are mounted/unmounted at runtime.Type of Change
Related Issue
Closes #148
Closes #150
Testing
Manual Testing
Build Verification
All unit tests pass including the new
MountedVolumeObserverTests.Checklist
dev