Disabled the "Sign in with Google" (and get contacts from Google/gmai… - #4866
Merged
Merged
Conversation
…l) for Android. Android needs a new "Sign in with Google" implementation due to new OAuth requirements at Google. Dale said to disable it for now for Android, pending a UI redesign. The Friends page navigation has been broken and loopy for years with tons of bad copied code and a patched UI that has confusingly labeled buttons. So this "disabling change" for Android hit in many places. Some of those pages are very hard to navigate to. Friends needs a "from zero" UI design and a complete code rewrite.
Member
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…l) for Android.
Android needs a new "Sign in with Google" implementation due to new OAuth requirements at Google. Dale said to disable it for now for Android, pending a UI redesign.
The Friends page navigation has been broken and loopy for years with tons of bad copied code and a patched UI with confusingly labeled buttons. So this "disabling change" for Android hit in many places. Some of those pages are very hard to navigate to. So I patched it some more -- Friends needs a "from zero" UI redesign and a complete code rewrite.