chore(ci): gate docs publish on next only#697
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 970390ec2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| push: | ||
| branches: # Allow list of deployable tags and branches. Note that all allow-listed branches cannot include any `/` characters | ||
| - next | ||
| - task-refactor |
There was a problem hiding this comment.
For any push to task-refactor with changed packages, this new branch filter runs the entire deploy workflow, not just the documentation job; the existing publish-npm deploy step still publishes packages with --tag ${GITHUB_REF##*/} before the docs job is skipped. If the intent is only to prevent docs publishing outside next, this also opens NPM publishing, release tagging, PR comments, and Webex notifications from task-refactor, so either remove this trigger or add matching branch guards to the publishing/tagging jobs.
Useful? React with 👍 / 👎.
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
Superseded by #698 so the follow-up branch uses the plain name |
2 participants
This pull request addresses
This follow-up PR brings the same
publish-documentationguard ontonextso the deploy workflow behavior is aligned there as well.by making the following changes
if: github.ref_name == 'next'to thepublish-documentationjob in.github/workflows/deploy.ymlNotes
nexttask-refactor-based work so deployment behavior is consistent once merged