Pause timeline playhead following once the user pans or zooms - #74
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Following owned scrollLeft outright, so a pan or wheel-zoom during playback was undone on the next frame. Any scroll position the follow effect did not write is the user's; leave the window alone until the next play/pause. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
wassgha
force-pushed
the
fix/timeline-follow-scroll
branch
from
August 6, 2026 04:33
82bb25d to
07fa970
Compare
wassgha
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same conflict #71 fixed in the transcript, in the timeline.
Problem
Playhead following owned
scrollLeftunconditionally while playing: pan the track or wheel-zoom into a detail and the next frame yanked the window back to the playhead.Fix
The existing "keep the playhead visible while playing" effect is unchanged in behaviour — it just stops running once the user takes over. A scroll position the effect did not write itself is the user's, so following pauses until the next play/pause.
Attribution is by comparing the scroll event's
scrollLeftagainst the last value the effect wrote, which covers trackpad panning, the scrollbar, keyboard, and the anchor-preserving scroll that wheel-zoom applies.17 added lines, no new UI.
Testing
tsc --noEmitandeslintare clean. Not exercised by hand in the app — the interaction wants a real media file and playback to judge.