Skip to content

Remove "JSON" language from card render suite. - #59

Merged
dmitrizagidulin merged 1 commit into
mainfrom
rename-json-card
Aug 11, 2026
Merged

Remove "JSON" language from card render suite.#59
dmitrizagidulin merged 1 commit into
mainfrom
rename-json-card

Conversation

@msporny

@msporny msporny commented Aug 9, 2026

Copy link
Copy Markdown
Member

This PR is an attempt to partially address issue #55 by removing the "JSON" text from the "JSON Card" render suite name. A card is meant to quickly express the most important information about the credential in a way that is easily consumable and matches the native UX of the wallet.

The change to the language is meant to remove some confusion around developers wondering exactly what a "JSON Card" is. The "JSON" part is an implementation detail, the important UX mechanism is the "card" UX format itself.


Preview | Diff

@dlongley dlongley left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with this as I don't think "JSON" is the right thing to highlight, but I also think "card" isn't the right thing to highlight either. This renderer could be used in a "list view", for example, which will not render "UI cards" (but something similar). So I still think we need a better name, but this is a step in the right direction, IMO.

@iherman iherman left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added a set of comment on the section as a whole in #61. I let the editors decide whether they would be taken care of in this PR or whether they would be the subject of a separate one.

I also agree with the comment of @dlongley on the term "card".

@TallTed

TallTed commented Aug 10, 2026

Copy link
Copy Markdown
Member

"card" does seem too simple to bother with. Like "index card". What would the schema of an "index card" be? "line 1", "line 2", "line 3"? I'll think more and hope someone finds inspiration.

@msporny

msporny commented Aug 10, 2026

Copy link
Copy Markdown
Member Author

"card" does seem too simple to bother with. Like "index card". What would the schema of an "index card" be? "line 1", "line 2", "line 3"? I'll think more and hope someone finds inspiration.

Well, that's why we don't use "index card" -- it's a specific type of card... what we're trying to say here is "it should fit on a card, here are the field names and values, card color... and that's about it."

@dmitrizagidulin dmitrizagidulin left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kezike

kezike commented Aug 11, 2026

Copy link
Copy Markdown

Still feeling like something like item (featured as an item in a list view) or overview (captures core details of credential) are more appropriate, but not enough to block this PR if there is enough consensus around card.

@dmitrizagidulin

Copy link
Copy Markdown
Collaborator

Discussed on 2026-08-11 call.
Proposed we merge this PR as a strict improvement, and open a separate discussion whether to rename 'card view' to something like 'list view' or 'data view'.
See also Ivan's issue: #61

@dmitrizagidulin
dmitrizagidulin merged commit 7fe97f3 into main Aug 11, 2026
1 of 2 checks passed
@dmitrizagidulin
dmitrizagidulin deleted the rename-json-card branch August 11, 2026 15:37
@msporny

msporny commented Aug 11, 2026

Copy link
Copy Markdown
Member Author

@kezike wrote:

Still feeling like something like item (featured as an item in a list view) or overview (captures core details of credential)

Yeah, I've been wondering if "overview" or "summary" would be a better name than "card". How do people feel about "summary" (or something in that vein)?

The only other thing to think about is with the "html" render method, which could do "summaries" as well. We've also been thinking about "tags" on render methods like "front" and "back" or ["front", "summary"]? The selection logic gets complicated quickly, so a bit unsure about the 'tags' concept.

@iherman

iherman commented Aug 12, 2026

Copy link
Copy Markdown
Member

Still feeling like something like item (featured as an item in a list view) or overview (captures core details of credential)

Yeah, I've been wondering if "overview" or "summary" would be a better name than "card". How do people feel about "summary" (or something in that vein)?

This isn't convincing. Overview/summary feels that some details are glossed over for an overall understanding of the data, and this is not the case.

My vote, at this moment, would go to "data view". This method concentrates on selecting part of the data of the credential, which is then provided as input (well, input data) for a real rendering that we do not know about...

@msporny

msporny commented Aug 12, 2026

Copy link
Copy Markdown
Member Author

@iherman wrote:

This isn't convincing. Overview/summary feels that some details are glossed over for an overall understanding of the data, and this is not the case.

Hmm, I think that is exactly the case, isn't it? :)

The card/overview/summary doesn't include every piece of information in the credential, it just includes the things that the individual is most likely to care about... thus, it's a overview/summary view of the data.

My vote, at this moment, would go to "data view". This method concentrates on selecting part of the data of the credential, which is then provided as input (well, input data) for a real rendering that we do not know about...

... but isn't "selecting part of the data of the credential" an overview/summary? Not enamored with any label that includes the word "data" because the word is so generic that it can mean many things to many people... and because it isn't just about the data, the view includes things like colors and logos. That said, I wouldn't object to this if the rest of the group wants to go with it.

@kezike

kezike commented Aug 13, 2026

Copy link
Copy Markdown

My vote, at this moment, would go to "data view". This method concentrates on selecting part of the data of the credential, which is then provided as input (well, input data) for a real rendering that we do not know about...

... but isn't "selecting part of the data of the credential" an overview/summary? Not enamored with any label that includes the word "data" because the word is so generic that it can mean many things to many people... and because it isn't just about the data, the view includes things like colors and logos. That said, I wouldn't object to this if the rest of the group wants to go with it.

My reservation with data has been the same: too broad of a term and could arguably be applied semantically to other render methods. So, if nothing else, I would like to apply a downvote to data or any name that includes it.

Another idea that I had in mind was native, since this render method is also concerned with rendering the credential fields in the native view of the app, but, as we are finding, it does not capture the entire essence of the method (native-overview/native-summary maybe?…not convinced about this though).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants