Remove "JSON" language from card render suite. - #59
Conversation
dlongley
left a comment
There was a problem hiding this comment.
I'm ok with this as I don't think "JSON" is the right thing to highlight, but I also think "card" isn't the right thing to highlight either. This renderer could be used in a "list view", for example, which will not render "UI cards" (but something similar). So I still think we need a better name, but this is a step in the right direction, IMO.
|
"card" does seem too simple to bother with. Like "index card". What would the schema of an "index card" be? "line 1", "line 2", "line 3"? I'll think more and hope someone finds inspiration. |
Well, that's why we don't use "index card" -- it's a specific type of card... what we're trying to say here is "it should fit on a card, here are the field names and values, card color... and that's about it." |
|
Still feeling like something like |
|
Discussed on 2026-08-11 call. |
|
@kezike wrote:
Yeah, I've been wondering if "overview" or "summary" would be a better name than "card". How do people feel about "summary" (or something in that vein)? The only other thing to think about is with the "html" render method, which could do "summaries" as well. We've also been thinking about "tags" on render methods like "front" and "back" or ["front", "summary"]? The selection logic gets complicated quickly, so a bit unsure about the 'tags' concept. |
This isn't convincing. Overview/summary feels that some details are glossed over for an overall understanding of the data, and this is not the case. My vote, at this moment, would go to "data view". This method concentrates on selecting part of the data of the credential, which is then provided as input (well, input data) for a real rendering that we do not know about... |
|
@iherman wrote:
Hmm, I think that is exactly the case, isn't it? :) The card/overview/summary doesn't include every piece of information in the credential, it just includes the things that the individual is most likely to care about... thus, it's a overview/summary view of the data.
... but isn't "selecting part of the data of the credential" an overview/summary? Not enamored with any label that includes the word "data" because the word is so generic that it can mean many things to many people... and because it isn't just about the data, the view includes things like colors and logos. That said, I wouldn't object to this if the rest of the group wants to go with it. |
My reservation with Another idea that I had in mind was |
This PR is an attempt to partially address issue #55 by removing the "JSON" text from the "JSON Card" render suite name. A card is meant to quickly express the most important information about the credential in a way that is easily consumable and matches the native UX of the wallet.
The change to the language is meant to remove some confusion around developers wondering exactly what a "JSON Card" is. The "JSON" part is an implementation detail, the important UX mechanism is the "card" UX format itself.
Preview | Diff