Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -1,12 +1,10 @@
# Cases that use the remote cache backend are ignored because it runs on
# Node.js. Windows is skipped because the PTY launcher cannot execute pnpm
# command shims. Whether an upload to the backend is still running when the
# tasks finish depends on timing, so steps that upload hide the message about
# Node.js. Whether an upload to the backend is still running when the tasks
# finish depends on timing, so steps that upload hide the message about
# pending uploads. The cases that test it stall the uploads instead, with
# stalled-remote-cache in front of the backend.
[[e2e]]
name = "read_write"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -39,7 +37,6 @@ steps = [

[[e2e]]
name = "read"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -73,7 +70,6 @@ steps = [

[[e2e]]
name = "restore"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -145,7 +141,6 @@ steps = [

[[e2e]]
name = "local_and_remote_hits"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -188,7 +183,6 @@ steps = [

[[e2e]]
name = "fallback"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -228,7 +222,6 @@ steps = [

[[e2e]]
name = "corrupt_archive"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -280,7 +273,6 @@ steps = [

[[e2e]]
name = "restore_failure"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -349,6 +341,9 @@ steps = [

[[e2e]]
name = "pending_uploads"
# Skipped on Windows, where a milestone is the console title and ConPTY sends
# only the latest one when it next renders: the proxy's `stalled` milestone for
# check's upload can replace `uploads-pending`.
cfg = "not(windows)"
ignore = true
steps = [
Expand Down Expand Up @@ -562,7 +557,6 @@ steps = [

[[e2e]]
name = "ctrl_c_during_upload"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand Down Expand Up @@ -597,7 +591,6 @@ steps = [

[[e2e]]
name = "fast_fail_during_upload"
cfg = "not(windows)"
ignore = true
steps = [
{ argv = [
Expand All @@ -622,6 +615,8 @@ steps = [

[[e2e]]
name = "hide_pending_uploads"
# Skipped on Windows, where a milestone is the console title and ConPTY sends
# it only when it next renders: nothing is printed after `uploads-pending`.
cfg = "not(windows)"
ignore = true
steps = [
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,5 @@
# Windows is skipped because the PTY launcher cannot execute pnpm command shims.
[[e2e]]
name = "entries_and_associations"
cfg = "not(windows)"
ignore = true
steps = [
[
Expand Down Expand Up @@ -96,7 +94,6 @@ steps = [

[[e2e]]
name = "blob_replacement"
cfg = "not(windows)"
ignore = true
steps = [
[
Expand Down Expand Up @@ -209,7 +206,6 @@ steps = [

[[e2e]]
name = "opaque_binary_data"
cfg = "not(windows)"
ignore = true
steps = [
[
Expand Down Expand Up @@ -264,7 +260,6 @@ steps = [

[[e2e]]
name = "invalid_requests"
cfg = "not(windows)"
ignore = true
steps = [
[
Expand Down Expand Up @@ -433,7 +428,6 @@ steps = [

[[e2e]]
name = "state_across_invocations"
cfg = "not(windows)"
ignore = true
steps = [
[
Expand Down
2 changes: 2 additions & 0 deletions packages/tools/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"cbor-edn": "catalog:",
"cbor2": "catalog:",
"cross-env": "catalog:",
"cross-spawn": "catalog:",
"deno": "catalog:",
"oxfmt": "catalog:",
"oxlint": "catalog:",
Expand All @@ -33,6 +34,7 @@
"vitest": "catalog:"
},
"devDependencies": {
"@types/cross-spawn": "catalog:",
"vite-task-tools": "workspace:*"
}
}
3 changes: 2 additions & 1 deletion packages/tools/src/remote-cache/cli.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env node
import { spawn } from 'node:child_process';
import { once } from 'node:events';
import type { AddressInfo } from 'node:net';
import spawn from 'cross-spawn';
import { createCacheServer } from './server.ts';

const basePath = '/projects/test';
Expand All @@ -18,6 +18,7 @@ await once(server, 'listening');
const { port } = server.address() as AddressInfo;
// Ctrl-C is left to the command.
process.on('SIGINT', () => {});
// cross-spawn runs pnpm's `.cmd` shims, such as `cbor-http`, on Windows.
const child = spawn(command!, args, {
stdio: 'inherit',
env: { ...process.env, VP_REMOTE_CACHE_URL: `http://127.0.0.1:${port}${basePath}` },
Expand Down
19 changes: 19 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions pnpm-workspace.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ catalog:
'@fastify/busboy': 3.2.2
'@openai/codex': 0.160.0
'@tsconfig/strictest': ^2.0.8
'@types/cross-spawn': 6.0.6
'@types/node': 25.0.3
'@playwright/browser-chromium': 1.63.0
'@vitest/browser-playwright': 5.0.3
bun: 1.4.2
cbor-edn: 0.2.2
cbor2: 1.12.0
cross-env: ^10.1.0
cross-spawn: 7.0.6
deno: 2.9.6
husky: ^9.1.7
lint-staged: ^17.0.0
Expand Down
Loading