musescore: update to 4.7.0#57968
Conversation
5dfd314 to
ab33db1
Compare
|
While looking into a MuseScore update, I noticed this PR also switches flac, libogg, and libsndfile to CMake. I’m not opposed to the change, but I might be missing some context: what’s the rationale? According to upstream documentation, all three projects still support both autotools and CMake. In particular, libogg and libsndfile describe autotools as the primary or recommended build system, while FLAC treats both as equivalent. For reference, I built MuseScore 4.6.4 locally against the current packages, without these build-system changes, and the build completed successfully. The only thing I noticed was CMake warnings about missing package config files for FLAC and libsndfile (SndFile) (e.g. I also tested the resulting build locally, and everything is working perfectly on my side. Thanks for working on this update. Given that, is the goal mainly to provide CMake package config files/targets for these libraries and eliminate those warnings, or is there a concrete MuseScore-related failure with the autotools-built variants? |
|
Bundled deps vs system deps |
ab33db1 to
7c9b2ca
Compare
|
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it. |
|
Bump |
|
Would it be possible to patch this PR to resolve the issue I outlined in: musescore/MuseScore#32911 or should we wait until this is patched upstream. The main thing is that the issue is with the MuseSampler shared lib which is closed-source. TLDR; the fix is:
|
|
no, upstream should fix it first |
|
Is there anything blocking this PR from being merged at the moment? |
I made changes so that
musescorecould find the packages below:flac,libogg,libsndfileto cmakeadded lame.pc tonot allowed, thus removedlamelibflacwithflacas a dep inlibflac-devel, because/usr/lib64/cmake/FLAC/targets.cmakerequires binaries.Testing the changes
Local build testing