fix(gui): invalid chunk/pad range, fix slider minimum#616
fix(gui): invalid chunk/pad range, fix slider minimum#616brandostrong wants to merge 3 commits intovoicepaw:mainfrom
Conversation
librosa.util.exceptions.ParameterError: Invalid hop_length: 0 on 0 chunk seconds Calculated padded input size per channel: (1). Kernel size: (2). Kernel size can't be greater than actual input size on 0 pad seconds
|
I would appreciate it if you could fix other sliders as well |
|
Hi, can you clarify? |
|
It would be nice if the slider for the maximum chunk seconds and the four sliders for "Realtime" also had a proper minimum value. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #616 +/- ##
==========================================
+ Coverage 19.55% 19.56% +0.01%
==========================================
Files 39 39
Lines 3427 3424 -3
Branches 477 476 -1
==========================================
Hits 670 670
+ Misses 2740 2737 -3
Partials 17 17 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…ault button bug All work done on gui.py
|
@brandostrong #649 is not a bug. (#95) If you think it is really unfriendly, please create the feature to make the default at startup the same as the last time, or show additional prompts, etc. please create a separate PR for that. Also, I personally think a lower limit of 0.01 seconds for each slider would be preferable. |
|
hi, I now see why it is like this. It makes sense for the presets to change back to "default file" instead of any other preset, but should it update the selections with the default? Would a good comprimise be removing Otherwise, I can look at adding a toggle to "remember" settings. |
|
I don't even know what is the best solution, though I'd rather have a preset made than click on a toggle. |
librosa.util.exceptions.ParameterError: Invalid hop_length: 0 on 0 chunk seconds
Calculated padded input size per channel: (1). Kernel size: (2). Kernel size can't be greater than actual input size on 0 pad seconds