vk-agent/ssh: run an exec on the pty the client asked for - #7
Open
shelleu-wallix wants to merge 1 commit into
Open
shelleu-wallix wants to merge 1 commit into
shelleu-wallix wants to merge 1 commit into
Conversation
A pty-req followed by exec (`ssh -t host cmd`) ran the command on pipes and left the pty unused, as sshd does not. Zed opens every remote terminal as `ssh -t host 'cd <dir>; exec $SHELL -l'`, so its shell came up non-interactive, with no prompt, waiting on a stdin nobody wrote to: the terminal hung. The command now runs as `$SHELL -c` on that pty, bridged like the interactive shell (resizes, hang-up, exit status). An exec without a pty keeps its pipes and separate stderr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pty-req followed by exec (
ssh -t host cmd) ran the command on pipes and left the pty unused, as sshd does not.Zed opens every remote terminal as
ssh -t host 'cd <dir>; exec $SHELL -l', so its shell came up non-interactive, with no prompt, waiting on a stdin nobody wrote to: the terminal hung.The command now runs as
$SHELL -con that pty, bridged like the interactive shell (resizes, hang-up, exit status). An exec without a pty keeps its pipes and separate stderr.