fix: add missing xmlns:xlink namespace for Mermaid PNG export#547
Closed
highoncomputers wants to merge 1 commit into
Closed
fix: add missing xmlns:xlink namespace for Mermaid PNG export#547highoncomputers wants to merge 1 commit into
highoncomputers wants to merge 1 commit into
Conversation
Mermaid SVG output sometimes uses xlink:href attributes without declaring the xmlns:xlink namespace on the root <svg> element. When converting SVG to PNG via canvas, browsers require valid XML and fail to load the image, causing the PNG export to silently fail. Fix by detecting xlink:href usage and injecting the required namespace. Closes #541
Contributor
|
@highoncomputers is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mermaid SVG output sometimes uses
xlink:hrefattributes without declaring the requiredxmlns:xlinknamespace on the root<svg>element. When converting SVG to PNG via canvas insvgToPngBlob, browsers require valid XML and fail to load the image if the namespace is missing, causing PNG export to silently fail.Fix: Added a
normalizeSvghelper that detectsxlink:hrefusage and injectsxmlns:xlink=http://www.w3.org/1999/xlinkon the root SVG element when missing.Closes #541