Preserve glibc 2.36 runtime compatibility - #365
Merged
Merged
Conversation
- Pin GNU runtime packs to glibc 2.36 Zig targets and reject incompatible imports. - Provision verified Zig builds and exercise published artifacts on Debian Bookworm. Fixes #349 Co-authored-by: Cruel <383999+Cruel@users.noreply.github.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
RavensBlood1313
approved these changes
Sep 21, 2026
| - uses: vercel-labs/setup-zig@v1 | ||
| with: | ||
| version: 0.16.0 | ||
| - run: CC=zig AR=zig pnpm --filter @scriptc/runtime-linux-x64-gnu build:native |
There was a problem hiding this comment.
Suggested change
| - run: CC=zig AR=zig pnpm --filter @scriptc/runtime-linux-x64-gnu build:native | |
| - run: CC=zig AR=zig pnpm --filter @scriptc/runtime-linux-x64-gnu build:native |
| run: | | ||
| node packages/cli/dist/main.js build tests/corpus/001-hello.ts -o "$RUNNER_TEMP/hello" | ||
| test "$("$RUNNER_TEMP/hello")" = 'hello world' | ||
| - name: Debian 12 glibc 2.36 runtime-pack smoke |
There was a problem hiding this comment.
Suggested change
| - name: Debian 12 glibc 2.36 runtime-pack smoke | |
| - name: Debian 12 glibc 2.36 runtime-pack smoke |
| node packages/cli/dist/main.js build tests/corpus/001-hello.ts -o "$RUNNER_TEMP/hello" | ||
| test "$("$RUNNER_TEMP/hello")" = 'hello world' | ||
| - name: Debian 12 glibc 2.36 runtime-pack smoke | ||
| run: | |
There was a problem hiding this comment.
Suggested change
| run: | | |
| run: | | |
| - ```… |
| @@ -13,12 +13,7 @@ pnpm install && pnpm -r build # build the workspace | |||
| pnpm test:sandbox # full gate: ~4m custom image, ~9m cold managed fallback | |||
| ``` | |||
| matching `@scriptc/llvm-<platform>` and `@scriptc/runtime-<platform>` | ||
| `build:native` scripts explicitly. The macOS full test suite also needs its | ||
| generated artifacts. | ||
| The ordinary workspace build does not rebuild packaged native artifacts. When changing native assembly/object emission or runtime-pack selection, install CMake, Ninja, the pinned LLVM 22 development package, and Zig 0.16.0, then run the matching `@scriptc/llvm-<platform>` and `@scriptc/runtime-<platform>` `build:native` scripts explicitly. The macOS full test suite also needs its generated artifacts. |
There was a problem hiding this comment.
Suggested change
| The ordinary workspace build does not rebuild packaged native artifacts. When changing native assembly/object emission or runtime-pack selection, install CMake, Ninja, the pinned LLVM 22 development package, and Zig 0.16.0, then run the matching `@scriptc/llvm-<platform>` and `@scriptc/runtime-<platform>` `build:native` scripts explicitly. The macOS full test suite also needs its generated artifacts. | |
| The ordinary workspace build does not rebuild packaged native artifacts. When changing native assembly/object emission or runtime-pack selection, install CMake, Ninja, the pinned LLVM 22 development package, and Zig 0.16.0, then run the matching `@scriptc/llvm-<platform>` and `@scriptc/runtime-<platform>` `build:native` scripts explicitly. The macOS full test suite also needs its generated artifacts. |
|
|
||
| ARG NODE_VERSION | ||
| ARG PNPM_VERSION=11.1.3 | ||
| ARG ZIG_VERSION=0.16.0 |
There was a problem hiding this comment.
Suggested change
| ARG ZIG_VERSION=0.16.0 | |
| ARG ZIG_VERSION=0.16.0 |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin GNU runtime packs to glibc 2.36 Zig targets and reject incompatible imports.
Provision verified Zig builds and exercise published artifacts on Debian Bookworm.
Fixes #349