Unify TS 7 project module resolution - #308
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pathsin the TypeScript 7 program, normalize inherited/baseUrl-relative targets, and give scriptc's resolver the identical maprequire()through one project-module resolver before npm fallbackCloses #239.
This incorporates the TypeScript 7 paths intent from #197 and the bare project dynamic-import portion of #200 on top of the current resolver architecture.
Validation
pnpm -r buildpnpm exec vitest run packages/compiler/src/frontend/resolve.test.ts packages/compiler/test/ts7— 94 passedpnpm node-compat:checkcd docs && NEXT_DIST_DIR=.next-check pnpm checkpnpm test:sandbox: all 16 Linux plain/sanitized Sandbox lanes passed. Four local lanes initially started before the ignored Darwin helper/runtime artifacts existed; after building the pinned LLVM 22.1.8 helper and matching runtime pack, the exact gate-equivalent local matrix passed in both lanes: