Skip to content

Numpy 2.0 compatability#21

Merged
vaipatel merged 2 commits into
vaipatel:masterfrom
schlegelp:master
Jul 18, 2026
Merged

Numpy 2.0 compatability#21
vaipatel merged 2 commits into
vaipatel:masterfrom
schlegelp:master

Conversation

@schlegelp

Copy link
Copy Markdown
Contributor

This PR replaces a small number of numpy functions that have recently been dropped, namely np.row_stack and np.core.char.add.

I also escaped docstrings - currently they trigger a SyntaxWarning but would have caused a SyntaxError in the future.

With the above, morphops should work with modern numpy.

For reviewers

  • New features, API changes, and deprecations are mentioned in the unreleased
    section in CHANGELOG.rst.

@vaipatel vaipatel left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Verified locally with NumPy 2.x, lgtm!

@vaipatel

Copy link
Copy Markdown
Owner

CI is failing only on the legacy Python 3.5 job, seems GitHub Actions can no longer provision Python 3.5 on the current runner. The PR changes were verified locally with NumPy 2.x, and the remaining 3.8/3.9 CI jobs pass. I’ll handle the CI matrix cleanup separately after merging.

@vaipatel
vaipatel merged commit 6a11ef4 into vaipatel:master Jul 18, 2026
6 of 7 checks passed
@vaipatel

Copy link
Copy Markdown
Owner

@all-contributors please add @schlegelp for code

@allcontributors

Copy link
Copy Markdown
Contributor

@vaipatel

I've put up a pull request to add @schlegelp! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants