Skip to content

docs: add Dialog slide animation example - #6187

Merged
sissbruecker merged 3 commits into
mainfrom
docs/component-styling-layout-snippets
Oct 1, 2026
Merged

sissbruecker merged 3 commits into
mainfrom
docs/component-styling-layout-snippets

Conversation

@totally-not-ai

@totally-not-ai totally-not-ai Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Summary

This adds an example to the Dialog styling page. It shows how to make a dialog slide up a little and fade in when it opens, then slide down and fade out when it closes.

What changed

Docs only. No code or behavior changes.

In articles/components/dialog/styling.adoc, after the overlay animation properties:

  • Aura / base styles: a short CSS example for dialogs with the slide-in class name. It sets --vaadin-overlay-translate-closed: 0 2rem and --vaadin-overlay-scale-closed: 1, so the dialog slides instead of scaling. The theme still controls the timing.
  • Lumo: Lumo has its own Dialog animation, so the properties above do nothing there. The example replaces the opening and closing overlay animations with keyframes that add a slide to the usual fade. It keeps Lumo's built-in durations, delays, and easing, so the dialog still matches the backdrop fade and is removed at the right time.

Add short examples for compact Combo Box items, per-instance Progress
Bar value color, user-resizable Text Area, Dialog slide-in animation,
printing part of a page, and Enter and Escape handling in dialogs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Sep 26, 2026 •

Copy link
Copy Markdown
Contributor

Preview Deployment

This PR has been deployed for preview.

URL: https://docs-preview-pr-6187.fly.dev

Changed pages

Added content is highlighted in green; removed content is marked in red on each page.

Built from 9287a15

@sissbruecker

Copy link
Copy Markdown
Member

@totally-not-ai Extract the dialogs / popovers guide and browser access changes into a separate PR.

They're now proposed in #6236.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@totally-not-ai totally-not-ai Bot changed the title docs: add component styling and layout tips docs: add component styling tips Oct 1, 2026
@totally-not-ai

totally-not-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@sissbruecker Done. The dialog keyboard shortcuts section (Add Dialogs & Popovers guide) and the selective printing snippet (Browser Access) are now in their own PR, #6236, and I removed them from this one.

@sissbruecker

Copy link
Copy Markdown
Member

@totally-not-ai

Drop the combo box progress bar and text area examples. These are either too arbitrary, promote bad practices or have broken UX.

For the dialog animation:

  • Don't make the dialog move over the whole screen.
  • Make the Lumo animation not look broken. The current timing doesn't match the built-in animation. Also overriding the animation removes the built-in opacity animation that Lumo has.

… animation

- Remove the Combo Box item spacing, Progress Bar color, and Text Area
  resize examples
- Dialog slide animation: slide a short distance instead of across the
  viewport, keep the theme's timing in Aura, and match Lumo's built-in
  durations, delays, easing, and fade

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@totally-not-ai totally-not-ai Bot changed the title docs: add component styling tips docs: add Dialog slide animation example Oct 1, 2026
@totally-not-ai

totally-not-ai Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

@sissbruecker Thanks for the review. I removed the Combo Box, Progress Bar, and Text Area examples, so this PR now only contains the Dialog animation. Changes to it:

  • The dialog now slides a short distance (2rem) instead of across the whole viewport.
  • In Aura, only --vaadin-overlay-translate-closed and --vaadin-overlay-scale-closed are set, so the theme's own durations, delay, and opacity fade still apply.
  • In Lumo, the opening and closing keyframes keep the built-in opacity fade and add the slide in place of the scale. They use the same durations, delays, and easing curves as Lumo's vaadin-dialog-enter / vaadin-dialog-exit (0.12s after 0.05s, and 0.1s after 0.03s), so they stay in sync with the backdrop and finish within the 0.25s Lumo waits before removing the dialog.

@sissbruecker
sissbruecker marked this pull request as ready for review October 1, 2026 17:28
@sissbruecker
sissbruecker merged commit fd0e3b2 into main Oct 1, 2026
10 checks passed
@sissbruecker
sissbruecker deleted the docs/component-styling-layout-snippets branch October 1, 2026 17:30
@sissbruecker sissbruecker added the target/v25.3 Automatically cherry-pick to the v25.3 branch label Oct 1, 2026
sissbruecker pushed a commit that referenced this pull request Oct 1, 2026
Co-authored-by: totally-not-ai[bot] <290682512+totally-not-ai[bot]@users.noreply.github.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cherry-picked-v25.3 target/v25.3 Automatically cherry-pick to the v25.3 branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants