Skip to content

clippy: fix assert_is_empty lint - #14355

Draft
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:clippy/assert_is_empty
Draft

clippy: fix assert_is_empty lint#14355
xtqqczze wants to merge 1 commit into
uutils:mainfrom
xtqqczze:clippy/assert_is_empty

Conversation

@xtqqczze

@xtqqczze xtqqczze commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

GNU testsuite comparison:

Skip an intermittent issue tests/misc/io-errors (fails in this run but passes in the 'main' branch)
Skip an intermittent issue tests/tail/symlink (fails in this run but passes in the 'main' branch)
Skipping an intermittent issue tests/rm/isatty (passes in this run but fails in the 'main' branch)
Skipping an intermittent issue tests/tail/tail-n0f (passes in this run but fails in the 'main' branch)
Note: The gnu test tests/printf/printf-surprise is now being skipped but was previously passing.

@xtqqczze
xtqqczze force-pushed the clippy/assert_is_empty branch from 2bdb7e1 to 24b5210 Compare September 2, 2026 23:18
@codspeed-hq

codspeed-hq Bot commented Sep 2, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 6.12%

⚡ 1 improved benchmark
✅ 360 untouched benchmarks
⏩ 50 skipped benchmarks1

Performance Changes

Mode Benchmark BASE HEAD Efficiency
Simulation ls_recursive_deep_tree[(200, 2)] 3.4 ms 3.2 ms +6.12%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing xtqqczze:clippy/assert_is_empty (43b30ca) with main (883b625)2

Open in CodSpeed

Footnotes

  1. 50 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

  2. No successful run was found on main (ddc98c2) during the generation of this report, so 883b625 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@xtqqczze
xtqqczze force-pushed the clippy/assert_is_empty branch from 24b5210 to 4e33342 Compare September 3, 2026 00:17
@xtqqczze
xtqqczze force-pushed the clippy/assert_is_empty branch from 4e33342 to 43b30ca Compare September 3, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant