cp: split a test - #14282
Open
xtqqczze wants to merge 1 commit into
Open
Conversation
oech3
reviewed
Aug 30, 2026
| #[test] | ||
| #[cfg(target_os = "linux")] | ||
| fn test_cp_reflink_always_failure() { | ||
| fn test_cp_reflink_always_invalid_argument() { |
Contributor
There was a problem hiding this comment.
I strongly disagree with separating 2 tests at least for. Because 2 test cases are exactly coming from same code path (thus, same logic).
Contributor
There was a problem hiding this comment.
Or just drop test for cross device.
Contributor
There was a problem hiding this comment.
does it really matter ? :)
tests are cheap
Contributor
There was a problem hiding this comment.
We just need to check that os errno is extracted at here.
Contributor
Author
There was a problem hiding this comment.
Tests should be as small as possible, but no smaller :)
Contributor
There was a problem hiding this comment.
I still disagree with separating 2 tests at least for.
|
Binary size comparison: |
|
GNU testsuite comparison: |
Contributor
|
@oech3 ok? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.