Implement the HTTP QUERY method (RFC 10008) in packages/http#42
Draft
ChiragAgg5k wants to merge 1 commit into
Draft
Implement the HTTP QUERY method (RFC 10008) in packages/http#42ChiragAgg5k wants to merge 1 commit into
ChiragAgg5k wants to merge 1 commit into
Conversation
Adds first-class support for the QUERY method in packages/http: routing via Http::query() and Router buckets, request body parsing in the FPM and Swoole adapters, the RFC-mandated 400 on missing Content-Type, and a Response::setAcceptQuery() helper emitting the Accept-Query structured field (RFC 9651).
Benchmark resultshttp — Swoole modes (4 cores, 200 VUs, 20s/run)
a = HYPERLOOP_A (process), b = HYPERLOOP_B (coroutine) Shared CI runners — treat absolute numbers as rough, compare modes within a run. Commit b534a86. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Implements RFC 10008 — The HTTP QUERY Method (Standards Track, June 2026) in
packages/http: a safe, idempotent HTTP method that carries the query as request content, for queries too large or too sensitive to encode in the URL.Replaces utopia-php/http#261, which was closed in favor of a monorepo PR.
Changes
Http::REQUEST_METHOD_QUERY/Request::METHOD_QUERYconstants, aQUERYbucket inRouter(includingreset()), and aHttp::query('/path')shortcut alongsideget()/post()/etc. Composes withHttp::routes([...])for multi-method routes.generateInput()for the FPM and Swoole adapters (SwooleCoroutine inherits), so a JSON QUERY body maps to route params exactly like POST.Content-Typeheader is rejected with a 400 through the normal error-hook pipeline before the route action runs.Response::setAcceptQuery([...])emits theAccept-Queryfield serialized as an RFC 9651 structured-field list of strings.Example
Out of scope
The RFC's caching rules (cache keys incorporating request content, normalization) and conditional-request semantics apply to caches; this library has no cache layer, so there is nothing to implement there.
Notes
QUERY. Worth verifying in the e2e/docker setup.Test Plan
7 new tests:
HttpTest(dispatch + 400 on missing Content-Type),RouterTest(QUERY matching isolated from GET),RequestTest(params come from the payload for QUERY),ResponseTest(Accept-Query serialization). Locally, the unit suite and phpstan show only pre-existing failures (missingUtopia\Systemclass inMode.php/ModeTest), identical on a clean checkout.Related PRs and Issues