Skip to content

Chore: Expose ssr files list to be public#15

Merged
Meldiron merged 1 commit into
mainfrom
chore-expose-ssr-files-list
Jul 1, 2026
Merged

Chore: Expose ssr files list to be public#15
Meldiron merged 1 commit into
mainfrom
chore-expose-ssr-files-list

Conversation

@Meldiron

@Meldiron Meldiron commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Useful for appwrite post-build SSR detection to only read and print relevant files, to reduce logs clutter

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown

Greptile Summary

This PR exposes the FRAMEWORK_FILES constant on the SSR class by changing its visibility from private to public, making the framework-to-SSR-file mapping accessible to external consumers without going through an instance method.

  • The constant was already used internally by getFiles(), so no behavioral change exists for existing callers; the only effect is that consumers like Appwrite's post-build pipeline can now access SSR::FRAMEWORK_FILES directly to enumerate relevant files without instantiating the class.
  • The sibling XStatic class has no equivalent constant (it always returns an empty array), so no consistency gap is introduced.

Confidence Score: 5/5

Safe to merge — the single-line visibility change has no effect on existing callers and introduces no new logic.

The change is a one-word visibility modifier on a read-only constant. Existing behavior is fully preserved, and the constant value itself is unchanged.

No files require special attention.

Important Files Changed

Filename Overview
src/Detection/Rendering/SSR.php Visibility of FRAMEWORK_FILES constant changed from private to public to allow external consumers to read the framework-to-files mapping directly.

Reviews (1): Last reviewed commit: "Expise ssr files list to be public" | Re-trigger Greptile

@Meldiron Meldiron merged commit 2b2744b into main Jul 1, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant