Skip to content

Only return external output resolver if the input resolver also goes to the external#2804

Merged
DavyLandman merged 1 commit into
mainfrom
fix/dont-fallback-for-readonly-schemes
Jun 17, 2026
Merged

Only return external output resolver if the input resolver also goes to the external#2804
DavyLandman merged 1 commit into
mainfrom
fix/dont-fallback-for-readonly-schemes

Conversation

@DavyLandman

Copy link
Copy Markdown
Member

This would lead to subtle bugs with write functions failing in ways that aren't expected.

@DavyLandman DavyLandman requested a review from rodinaarssen June 17, 2026 14:50
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 46%. Comparing base (6cff72e) to head (65da501).

Files with missing lines Patch % Lines
src/org/rascalmpl/uri/URIResolverRegistry.java 50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #2804   +/-   ##
=======================================
  Coverage       46%     46%           
- Complexity    6722    6729    +7     
=======================================
  Files          839     839           
  Lines        66766   66767    +1     
  Branches      9983    9983           
=======================================
+ Hits         30782   30794   +12     
+ Misses       33601   33595    -6     
+ Partials      2383    2378    -5     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DavyLandman DavyLandman merged commit 54de850 into main Jun 17, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants