Skip to content

fix(tui): use the is_running property for app guards that never fired (#894) #939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aniketshukla1 wants to merge 1 commit into from
Closed

fix(tui): use the is_running property for app guards that never fired (#894) #939

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions strix/interface/tui/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ def compose(self) -> ComposeResult:
yield SplashScreen(id="splash_screen")

def watch_show_splash(self, show_splash: bool) -> None:
if not show_splash and self.is_mounted:
if not show_splash and self.is_running:
try:
splash = self.query_one("#splash_screen")
splash.remove()
Expand Down Expand Up @@ -942,7 +942,7 @@ def _focus_chat_input(self) -> None:
if len(self.screen_stack) > 1 or self.show_splash:
return

if not self.is_mounted:
if not self.is_running:
return

try:
Expand All @@ -957,7 +957,7 @@ def _focus_agents_tree(self) -> None:
if len(self.screen_stack) > 1 or self.show_splash:
return

if not self.is_mounted:
if not self.is_running:
return

try:
Expand Down Expand Up @@ -989,7 +989,7 @@ def _update_ui(self) -> None:
if len(self.screen_stack) > 1:
return

if not self.is_mounted:
if not self.is_running:
return

try:
Expand Down Expand Up @@ -1128,7 +1128,7 @@ def _get_chat_content(
return self._get_rendered_events_content(events), "chat-content"

def _update_chat_view(self) -> None:
if len(self.screen_stack) > 1 or self.show_splash or not self.is_mounted:
if len(self.screen_stack) > 1 or self.show_splash or not self.is_running:
return

try:
Expand Down Expand Up @@ -1492,7 +1492,7 @@ def watch_selected_agent_id(self, _agent_id: str | None) -> None:
if len(self.screen_stack) > 1 or self.show_splash:
return

if not self.is_mounted:
if not self.is_running:
return

self._displayed_events.clear()
Expand Down Expand Up @@ -1565,7 +1565,7 @@ def _add_agent_node(self, agent_data: dict[str, Any]) -> None:
if len(self.screen_stack) > 1 or self.show_splash:
return

if not self.is_mounted:
if not self.is_running:
return

agent_id = agent_data["id"]
Expand Down Expand Up @@ -1704,7 +1704,7 @@ def handle_tree_highlight(self, event: Tree.NodeHighlighted) -> None:
if len(self.screen_stack) > 1 or self.show_splash:
return

if not self.is_mounted:
if not self.is_running:
return

node = event.node
Expand All @@ -1724,7 +1724,7 @@ def handle_tree_node_selected(self, event: Tree.NodeSelected) -> None:
if len(self.screen_stack) > 1 or self.show_splash:
return

if not self.is_mounted:
if not self.is_running:
return

node = event.node
Expand Down Expand Up @@ -1776,7 +1776,7 @@ def _get_agent_name(self, agent_id: str) -> str:
return "Unknown Agent"

def action_toggle_help(self) -> None:
if self.show_splash or not self.is_mounted:
if self.show_splash or not self.is_running:
return

try:
Expand All @@ -1794,7 +1794,7 @@ def action_toggle_help(self) -> None:
self.push_screen(HelpScreen())

async def action_request_quit(self) -> None:
if self.show_splash or not self.is_mounted:
if self.show_splash or not self.is_running:
await self.action_custom_quit()
return

Expand All @@ -1810,7 +1810,7 @@ async def action_request_quit(self) -> None:
self.push_screen(QuitScreen())

def action_stop_selected_agent(self) -> None:
if self.show_splash or not self.is_mounted:
if self.show_splash or not self.is_running:
return

if len(self.screen_stack) > 1:
Expand Down Expand Up @@ -1969,7 +1969,7 @@ def _safe_widget_operation(
return True

def on_resize(self, event: events.Resize) -> None:
if self.show_splash or not self.is_mounted:
if self.show_splash or not self.is_running:
return

try:
Expand Down