fix: Match the response action icons to the Bruno app (BRU-3765) - #31
Open
vasharma05-bruno wants to merge 5 commits into
Open
fix: Match the response action icons to the Bruno app (BRU-3765)#31vasharma05-bruno wants to merge 5 commits into
vasharma05-bruno wants to merge 5 commits into
Conversation
vasharma05-bruno
marked this pull request as draft
August 7, 2026 11:44
…dth for response actions
vasharma05-bruno
marked this pull request as ready for review
August 7, 2026 11:50
sachin-bruno
reviewed
Aug 7, 2026
|
|
||
| describe('ActionIconButton', () => { | ||
| it('renders a button with the accessible label and its child glyph', () => { | ||
| const html = renderToStaticMarkup( |
Contributor
There was a problem hiding this comment.
Please use UserenderToDOM everywhere for consistency
Contributor
Author
There was a problem hiding this comment.
Updated the tests
…o fix-response-action-buttons
sachin-bruno
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the size difference of response action buttons in Response Pane of the playground app (24px in Bruno app vs 28px in Bruno API Docs Playground)
Reason of regression
The initial idea was to reuse the
IconButtonwhich is currently being used at multiple places in the app. By design, the IconButton has the styles:Needed Sizes:
Since these styling configuration is needed only for the Action Buttons, a new component is created for the same.
Another changes:
monofont, and is bold500.0.75rem)0.125rem)Before
After