refactor(tests): adopt test-utils/dom helpers in unit specs - #27
Draft
vasharma05-bruno wants to merge 1 commit into
Draft
refactor(tests): adopt test-utils/dom helpers in unit specs#27vasharma05-bruno wants to merge 1 commit into
vasharma05-bruno wants to merge 1 commit into
Conversation
Use query/getByTestId/queryByTestId from src/test-utils/dom across specs: - replace element-existence .toBeTruthy() with the throwing getByTestId/query - convert required-element querySelector lookups to the helpers - route negative-existence checks through queryByTestId (assertions unchanged) Semantics preserved; non-DOM assertions (searchIndex) and querySelectorAll lookups are left untouched.
vasharma05-bruno
marked this pull request as ready for review
August 3, 2026 11:39
vasharma05-bruno
marked this pull request as draft
August 4, 2026 10:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adopts the
src/test-utils/domhelpers (query,getByTestId,queryByTestId) across unit specs and simplifies element-existence assertions:expect(...).toBeTruthy()→ the throwinggetByTestId/query(the throw is the assertion).querySelectorlookups →getByTestId/query.queryByTestId, keeping the.toBeNull()/.not.toBeNull()assertion.