Add function to plot PF coil dimensions in summary plot - #4499
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4499 +/- ##
==========================================
- Coverage 49.30% 49.15% -0.16%
==========================================
Files 151 151
Lines 29611 29707 +96
==========================================
+ Hits 14599 14601 +2
- Misses 15012 15106 +94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
clmould
left a comment
There was a problem hiding this comment.
I'm happy with these changes, just want a modeller to check the new figure first before I merge :)
|
Looks nice. Why not add the dimensions of the CS (since it is a PF coil)? |
The CS has its own page and dimension plot a few pages down in the summary. I will probably remove the CS from that plotting function and use the one that shows the full structure for all general plotting |
|
The OUT.DAT lists the coils as 0 to 5, not 1 to 6. (To be honest I don't know why.) |
Shall make an issue to fix this, should really index the coils from 1 |
I agree. |
|
#4502 to fix PF coil numbering |
This pull request introduces a new visualization for plotting the dimensions of PF (Poloidal Field) coils in the summary plotting workflow. The main change is the addition of the
plot_pf_dimensionsfunction, which visually annotates PF coil positions and dimensions on the plot, and its integration into the summary plotting routine.New PF Coil Visualization
plot_pf_dimensionsfunction tosummary.py, which plots the PF coil locations, dimensions, and annotations (ΔR and ΔZ) on a given axis, enhancing the clarity of PF coil geometry in the plots.Checklist
I confirm that I have completed the following checks: